From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SguiV-0000F0-Ra for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SguiO-0002Bi-Ft for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:27:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SguiO-0002BH-7l for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:27:12 -0400 Message-ID: <4FE045E8.6040803@redhat.com> Date: Tue, 19 Jun 2012 12:27:04 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20120611141806.GA2737@in.ibm.com> <20120611142144.GD2737@in.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Vijay Bellur , Amar Tumballi , qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, Paolo Bonzini On 06/18/2012 08:35 PM, Stefan Hajnoczi wrote: > On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao > wrote: >> +#include "block_int.h" >> +#include "gluster-helpers.h" >> + >> +typedef void *gluster_file_t; > > This typedef is already in gluster-helpers.h. It's ugly BTW, "typedef > struct gluster_file gluster_file_t" is nicer since it won't cast to > other pointer types automatically. gluster_file_t can only be cast to a NACK since names ending with _t are reserved by the C runtime. -- error compiling committee.c: too many arguments to function