From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgumj-0002qr-4B for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sgumc-0003av-S6 for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sgumc-0003aR-G5 for qemu-devel@nongnu.org; Tue, 19 Jun 2012 05:31:34 -0400 Message-ID: <4FE046EF.5020501@redhat.com> Date: Tue, 19 Jun 2012 11:31:27 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <20120531110608.4dc3fe22@doriath.home> <4FC77F6C.8000008@redhat.com> <20120531113127.1c8aa213@doriath.home> <4FC78637.4040605@redhat.com> <20120613144910.598bfe24@doriath.home> <4FDB6869.1000509@us.ibm.com> <20120615170350.GO16777@redhat.com> <4FDF7418.9070206@codemonkey.ws> <4FE02CB6.9090006@redhat.com> <20120619092044.GA12096@redhat.com> In-Reply-To: <20120619092044.GA12096@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Adding errno to QMP errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Anthony Liguori , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Anthony Liguori , Paolo Bonzini Am 19.06.2012 11:20, schrieb Daniel P. Berrange: > On Tue, Jun 19, 2012 at 09:39:34AM +0200, Kevin Wolf wrote: >> Am 18.06.2012 20:31, schrieb Anthony Liguori: >>> Irrespective of anything else, I think it's safe to say the experiment of "rich >>> errors" has been a failure. We still have way too many places using error_report. >>> >>> As I mentioned in another thread, I think we should: >>> >>> 1) Introduce a GENERIC_ERROR QError type. It could have a 'domain' and a 'msg' >>> field. >>> >>> 2) Focus on converting users of error_report over to use propagated Error objects. >>> >>> We shouldn't/can't change existing QError users. We also shouldn't consider >>> changing the wire protocol. But for new error users, we should/can relax the >>> reported errors. >>> >>> We need a clear support policy on whether the contents of 'msg' are stable or >>> not too. >> >> Another point that you used to bring up in earlier discussions is >> translated error messages. If we start returning error messages that are >> meant to displayed to the user, should we get your gettext patches >> applied which you did for the GTK backend? libvirt would then have to >> pay attention to start qemu with the same locale as the client has. > > You can't really start the VM in the same locale as the client app, > because there's no persistent 1:N relationship between libvirt clients > and VMs - it is M:N, so you can't choose a single VM. In addition there > is a bunch of work that libvirt does against VMs in contexts that have > no associated client. You just have to have 1 system wide locale for > all QEMU VMs on a host and libvirt. Good point. So if we ever needed it, we would have to introduce a monitor command to switch. But in most cases client and server locale should be the same anyway, so I think we can ignore that part for the start. Kevin