qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "\"陳韋任 (Wei-Ren Chen)\"" <chenwj@iis.sinica.edu.tw>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?
Date: Tue, 19 Jun 2012 14:12:41 +0200	[thread overview]
Message-ID: <4FE06CB9.6000202@suse.de> (raw)
In-Reply-To: <20120619115403.GA49013@cs.nctu.edu.tw>

Am 19.06.2012 13:54, schrieb 陳韋任 (Wei-Ren Chen):
>> If you only have one CPU then using first_cpu->some_field1 should be
>> almost as easy. :)
> 
>   I am afraid first_cpu (CPUArchState) is got poisoned, too. :/
> Even I comment out CPUArchState from poison.h,
> 
> --- vl.c
> extern CPUArchState *first_cpu;
> 
> static void main_loop(void)
> {
>     ... snip ...
> 
>     printf("%d", first_cpu->created);
> }
> ---
> 
> I still get compilation error below,
> 
> ---
> /tmp/chenwj/qemu/vl.c:1548:20: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
> /tmp/chenwj/qemu/vl.c: In function 'main_loop':
> /tmp/chenwj/qemu/vl.c:1568:18: error: 'first_cpu' undeclared (first use in this function)
> ---
> 
>   Any thought on what I am missing? Thanks.

Sorry, my mistake: vl.c is not compiled per-target like I thought but
per target_phys_addr_t in libhwX, thus it cannot access cpu.h or
CPUArchState (only CPUState). That means evaluations of fields in
CPUARMState need to be done in target-arm/ and you might want to check
the Notifiers or in the worst case _atexit() to hook some callback
function up. With QOM CPUState there's finalizers in theory but I don't
think they get called yet for anything except linux-user thread exit.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      parent reply	other threads:[~2012-06-19 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-18  7:47 [Qemu-devel] Any better way to access CPUArchState in vl.c? 陳韋任 (Wei-Ren Chen)
2012-06-18 10:01 ` Andreas Färber
2012-06-19  9:02   ` 陳韋任 (Wei-Ren Chen)
2012-06-19  9:54     ` Andreas Färber
2012-06-19 11:54       ` 陳韋任 (Wei-Ren Chen)
2012-06-19 12:08         ` Peter Maydell
2012-06-20  8:03           ` 陳韋任 (Wei-Ren Chen)
2012-06-19 12:09         ` Peter Crosthwaite
2012-06-19 13:21           ` Andreas Färber
2012-06-19 12:12         ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE06CB9.6000202@suse.de \
    --to=afaerber@suse.de \
    --cc=chenwj@iis.sinica.edu.tw \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).