From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory
Date: Tue, 19 Jun 2012 17:24:34 +0200 [thread overview]
Message-ID: <4FE099B2.1060504@suse.de> (raw)
In-Reply-To: <CAFEAcA_u164U-Px2DpxSofyQU8xyiP3J6SyuOuaG834HUXZW2g@mail.gmail.com>
Am 19.06.2012 17:18, schrieb Peter Maydell:
> On 14 June 2012 16:14, Andreas Färber <afaerber@suse.de> wrote:
>> Commit ec5b06d (configure: ensure directory exists when creating symlinks)
>> moved the creation of directories into the symlink() function but forgot
>> the case where no symlink is created.
>>
>> This leads to build errors on arm Linux due to -I../linux-headers.
>>
>> Unbreak the build on arm Linux by reverting part of that commit.
>
> I think it would be better to just revert ec5b06d completely.
> The comment documenting the symlink() function says
> "# symbolically link $1 to $2. Portable version of "ln -sf"
> and "ln -sf" doesn't create the target directory, so symlink()
> should not either.
I don't mind either way as long as the build gets fixed. Anthony?
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-06-19 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 15:14 [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory Andreas Färber
2012-06-14 15:56 ` Andreas Färber
2012-06-19 15:18 ` Peter Maydell
2012-06-19 15:24 ` Andreas Färber [this message]
2012-06-20 10:42 ` Peter Maydell
2012-06-20 16:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE099B2.1060504@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).