From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh0rQ-0001BA-MI for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:01:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sh0rL-0003AN-3h for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:00:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh0rK-0003AD-RS for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:00:51 -0400 Message-ID: <4FE0A225.4080201@redhat.com> Date: Tue, 19 Jun 2012 10:00:37 -0600 From: Eric Blake MIME-Version: 1.0 References: <1340120601-24747-1-git-send-email-owasserm@redhat.com> <1340120601-24747-2-git-send-email-owasserm@redhat.com> In-Reply-To: <1340120601-24747-2-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig115A806FBB5DF765E906B1DC" Subject: Re: [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Isaku Yamahata , avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig115A806FBB5DF765E906B1DC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2012 09:43 AM, Orit Wasserman wrote: > From: Isaku Yamahata >=20 > Signed-off-by: Isaku Yamahata > --- > =20 > -static void block_set_params(int blk_enable, int shared_base, void *op= aque) > +static void block_set_params(const MigrationParams *params, void *opaq= ue) As long as we are changing this signature... > @@ -394,9 +393,13 @@ void qmp_migrate(const char *uri, bool has_blk, bo= ol blk, > Error **errp) > { > MigrationState *s =3D migrate_get_current(); > + MigrationParams params; > const char *p; > int ret; > =20 > + params.blk =3D blk; =2E..and since blk is only ever a bool to begin with... > =20 > +struct MigrationParams { > + int blk; > + int shared; =2E..why not use bool instead of int in this struct to represent the fact= that it really is a binary choice? I think the same can be said for shar= ed. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig115A806FBB5DF765E906B1DC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP4KInAAoJEKeha0olJ0NqjqwH/3byFqtq5NtpQ+kJI81u0oS3 Nv4656QyNeAFu+hEyVVzjRRjTkPkmMFODUhy6oF3KXLkgIDenPc3jUGi2g42+uGF b0xcc9Z/ju9GfLcXfJt5o3NNt6oOw5bGlbIthUjlMs08mSGkKICcKWfbaCfifviS KslD6a73KKnaKYaqreMEBxIBzNO9ckrpChiQZGRmCQEdpd8J5mqOmPP+NtA4SRSw PcEiYgGf3Zrv3gwWJhO88izUFf8k/UJsxzAlCcDrqj0NurD+bl2e3CFu56eq3hdi 5Azo9tO3l7byZLGHlKIsLfdUT+nDLMtKsOR8uYIMk5Zm/XHOLaLVBS+ib/QgPbE= =kgoK -----END PGP SIGNATURE----- --------------enig115A806FBB5DF765E906B1DC--