From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh1HX-0000l6-Au for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:27:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sh1HV-0001fz-GH for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:27:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh1HV-0001fg-8M for qemu-devel@nongnu.org; Tue, 19 Jun 2012 12:27:53 -0400 Message-ID: <4FE0A87E.3030708@redhat.com> Date: Tue, 19 Jun 2012 10:27:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1340120601-24747-1-git-send-email-owasserm@redhat.com> <1340120601-24747-3-git-send-email-owasserm@redhat.com> In-Reply-To: <1340120601-24747-3-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig533FC086C28983E8F5B2937D" Subject: Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig533FC086C28983E8F5B2937D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Add migration capabiltes that can be queried by the management. s/capabiltes/capabilities/ > The managment can query the source QEMU and the destination QEMU in ord= er to s/managment/management/ > verify both support some migration capability (currently only XBZRLE).= > The managment can enable a capabilty for the next migration by using s/managment/management/ s/capabilty/capability/ > migrate_set_parameter command. >=20 > + > +STEXI > +@item migrate_set_parameter @var{capabilty} @var{state} s/capabilty/capability/ > +@findex migrate_set_parameter > +Enable/Disable the usage of a capability @var{capabilty} for migration= =2E s/capabilty/capability/ > +## > +# @migrate_set_parameters > +# > +# Set the following migration parameters (like xbzrle ) s/ )/)/ > +Example: > + > +-> { "execute": "query-migration-capabilities"} > +<- { "return": { "xbzrle" } s/}/} }/ Also, this doesn't match the earlier statement that this would be an array of MigrationCapabilityInfo, in which case this would be: { "return": [ { "capability": "xbzrle", "state": true } ] } or, someday in the future, { "return": [ { "capability": "xbzrle", "state": true }, { "capability": "foobar", "state": false } ] } > +Example: > + > +-> { "execute": "migrate_set_parameters" , "arguments": { "parameters"= : xbzrle on"} } Also wrong. Given the syntax, this would be: { "execute": "migrate-set-parameters", "arguments": { "parameters": [ { "capability": "xbzrle", "state": true } ] } } --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig533FC086C28983E8F5B2937D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP4Kh/AAoJEKeha0olJ0NqT70IAKmMgYSH9xK+/N2pSzR6RHls eJysjcw9UQOG0m39V4d7YOeisD8YEfUFtPMe9xEt2WNggslXRSxZ5npkNiGTFwlv cK+vtrDSlCmAdc9FDA3qGQjcBuCOWVg89I9zkZiQzuJ7wW9tOE+Eo55DngtlLNLN W++a8X7I7YZSnwNOiWt7BiRioJgXZKyY8saQvVNYr874LxR6ZX+ukUWM5qEMUPQ8 mzm3U82mvx3+hZ9YWJvzEXQ5Rqb/bOWQoDmhYorXDJOV9sLV6d7y9IzcEl7J6Z4b tEFdx7LxUboXBfCoajRCp/AlgFS9ss6/Q9JHti3fWS8XiLAKN2T3w11KX6MWKHc= =fdgS -----END PGP SIGNATURE----- --------------enig533FC086C28983E8F5B2937D--