From: Eric Blake <eblake@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com,
pbonzini@redhat.com, chegu_vinod@hp.com
Subject: Re: [Qemu-devel] [PATCH v12 05/13] Add uleb encoding/decoding functions
Date: Tue, 19 Jun 2012 10:59:21 -0600 [thread overview]
Message-ID: <4FE0AFE9.4040805@redhat.com> (raw)
In-Reply-To: <1340120601-24747-6-git-send-email-owasserm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On 06/19/2012 09:43 AM, Orit Wasserman wrote:
> Implement Unsigned Little Endian Base 128.
>
> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
> ---
> cutils.c | 29 +++++++++++++++++++++++++++++
> qemu-common.h | 8 ++++++++
> 2 files changed, 37 insertions(+), 0 deletions(-)
>
> +int uleb128_decode_small(const uint8_t *in, uint32_t *n)
> +{
> + if (!(*in & 0x80)) {
> + *n = *in++;
> + return 1;
> + } else {
> + *n = *in++ & 0x7f;
> + g_assert(!(*in & 0x80));
Are we really okay calling g_assert() in the middle of an incoming
migration, or are there more graceful ways to fail when dealing with
invalid user input?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-06-19 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 15:43 [Qemu-devel] [PATCH v12 00/13] XBZRLE delta for live migration of large memory app Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure Orit Wasserman
2012-06-19 16:00 ` Eric Blake
2012-06-19 16:02 ` Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 02/13] Add migration capabilites Orit Wasserman
2012-06-19 16:27 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 03/13] Add XBZRLE documentation Orit Wasserman
2012-06-19 16:46 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 04/13] Add cache handling functions Orit Wasserman
2012-06-19 16:51 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 05/13] Add uleb encoding/decoding functions Orit Wasserman
2012-06-19 16:59 ` Eric Blake [this message]
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 06/13] Add save_block_hdr function Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 07/13] Add debugging infrastructure Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 08/13] Change ram_save_block to return -1 if there are no more changes Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 09/13] Add migration_end function Orit Wasserman
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions Orit Wasserman
2012-06-19 18:08 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 11/13] Add XBZRLE to ram_save_block and ram_save_live Orit Wasserman
2012-06-19 18:50 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 12/13] Add set_cachesize command Orit Wasserman
2012-06-19 19:13 ` Eric Blake
2012-06-19 15:43 ` [Qemu-devel] [PATCH v12 13/13] Add XBZRLE statistics Orit Wasserman
2012-06-19 19:20 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE0AFE9.4040805@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=chegu_vinod@hp.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).