From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh3yc-00062d-Ul for qemu-devel@nongnu.org; Tue, 19 Jun 2012 15:20:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sh3ya-0006PG-WD for qemu-devel@nongnu.org; Tue, 19 Jun 2012 15:20:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sh3ya-0006Ot-Ni for qemu-devel@nongnu.org; Tue, 19 Jun 2012 15:20:32 -0400 Message-ID: <4FE0D0EB.8050105@redhat.com> Date: Tue, 19 Jun 2012 13:20:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1340120601-24747-1-git-send-email-owasserm@redhat.com> <1340120601-24747-14-git-send-email-owasserm@redhat.com> In-Reply-To: <1340120601-24747-14-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigA96793CBDDFA7A297DF06FFE" Subject: Re: [Qemu-devel] [PATCH v12 13/13] Add XBZRLE statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA96793CBDDFA7A297DF06FFE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2012 09:43 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > --- > +++ b/qapi-schema.json > @@ -263,7 +263,28 @@ > # Since: 0.14.0. > ## > { 'type': 'MigrationStats', > - 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int' } = } > + 'data': {'transferred': 'int', 'remaining': 'int', 'total': 'int', '= duplicate': 'int', 'norm': 'int' } } What does 'norm' mean? Is there something wrong with using an actual word instead of an abbreviation? Should 'duplicate' and 'norm' be marked optional, to reflect the fact that they were not always present in the output? Should the listing be: # Since: 0.14.0, 'duplicate' and 'norm' since 1.2. > + > +## > +# @CacheStats > +# > +# Detailed XBZRLE migration cache statistics > +# > +# @cache_size: XBZRLE cache size > +# > +# @xbzrle_bytes: amount of bytes already transferred to the target VM > +# > +# @xbzrle_pages: amount of pages transferred to the target VM > +# > +# @xbzrle_cache_miss: numer of cache miss s/numer/number > +# > +# @xbzrle_overflow: number of overflows > +# > +# Since: 1.1 1.2 > +## > +{ 'type': 'CacheStats', > + 'data': {'cache_size': 'int', 'xbzrle_bytes': 'int', 'xbzrle_pages':= 'int', > + 'xbzrle_cache_miss': 'int', 'xbzrle_overflow': 'int' } } s/_/-/g - prefer '-' over '_' in QMP > +++ b/qmp-commands.hx > @@ -2098,6 +2098,13 @@ The main json-object contains the following: > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > +- "cache": only present if "status" and XBZRLE is active. > + it is a json-object with the following XBZRLE information: s/it/It/ > + - "cache size": XBZRLE cache size > + - "xbzrle_bytes": total XBZRLE bytes transferred > + - "xbzrle_pages": number of XBZRLE compressed pages Alignment. Again, '-' instead of '_'. > +5. Migration is being performed and XBZRLE is active: > + > +-> { "execute": "query-migrate" } > +<- { > + "return":{ > + "status":"active", > + "ram":{ > + "total":1057024, > + "remaining":1053304, > + "transferred":3720 > + }, Where's the capabilities member? > + "cache":{ > + "size": 1024 No TABs. > + "xbzrle_transferred":20971520, Especially not when you mix TAB and space indentation in the same example= =2E > + "xbzrle_pages":2444343, > + "xbzrle_cache_miss:2244, s/miss:/miss"/ > + "xbzrle_overflow":34434 > + } > + } > + } > + > EQMP > =20 > { >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigA96793CBDDFA7A297DF06FFE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP4NDsAAoJEKeha0olJ0NqJmkH/j4IQPHcxIXtJn4mA1Wj8rPU LWY9FhnXpxkwJDhwVngwtbXWVk6CS6Ly5h/g1409WklUB/tYQSVnopU/ML0AyI6m 9fQ34hqHTgQGrosN/B9K/JdBBJhRjEdN/VEjTETGo2d/x5EVfmBshGC8BxQ4w+as gTrXrGdSmdSauxOUvkihbF6+4HNNVucEWoAzQEzXB0HcwDxneDjZXsBYkLxgdLKm TZsElfZ+Ll4zWDgOtRicYcp4hAKugup/2DknuaATDkxZW934NcyjQCrJpCuFqUu2 hwKIfzyHU4REpYrgCQ9f4TCIHIl+fRzCZ7x8tbkfZ96WhlfkG1sfyuW4BjyWh3g= =3iDJ -----END PGP SIGNATURE----- --------------enigA96793CBDDFA7A297DF06FFE--