From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKPv-0003CQ-Ss for qemu-devel@nongnu.org; Wed, 20 Jun 2012 08:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShKPo-00019o-Bh for qemu-devel@nongnu.org; Wed, 20 Jun 2012 08:53:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKPo-00017B-3l for qemu-devel@nongnu.org; Wed, 20 Jun 2012 08:53:44 -0400 Message-ID: <4FE1C7D4.4010507@redhat.com> Date: Wed, 20 Jun 2012 06:53:40 -0600 From: Eric Blake MIME-Version: 1.0 References: <1340167661-25499-1-git-send-email-akong@redhat.com> <1340167661-25499-6-git-send-email-akong@redhat.com> In-Reply-To: <1340167661-25499-6-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig801EA707EFE6620484B9B151" Subject: Re: [Qemu-devel] [PATCH v3 5/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig801EA707EFE6620484B9B151 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/19/2012 10:47 PM, Amos Kong wrote: > Convert 'sendkey' to use QAPI. do_sendkey() depends on some > variables/functions in monitor.c, so reserve qmp_sendkey() > to monitor.c >=20 > key_defs[] in monitor.c is the mapping of key name to keycode, > Keys' order in the enmu and key_defs[] is same. >=20 The interface looks like we have settled into something useful that libvirt can live with. I will leave a more thorough review of the series to those more familiar with qemu's internals. However, as long as we are fine-tuning things, I have some questions that might be worth one more spin: > +## > +# @sendkey: Should this be named 'send-key', given that most QMP commands separate words with '-' rather than squasheverythingtogether? > +SQMP > +sendkey > +---------- > + > +Send keys to VM. > + > +Arguments: > + > +keys array: > + - "key": key sequence (json-string) I'm not sure if json-string is the right designation any more. Rather, it is a json-array of key enum values. > + > +- hold-time: time to delay key up events, milliseconds (josn-int, opti= onal) s/josn/json/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig801EA707EFE6620484B9B151 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP4cfVAAoJEKeha0olJ0NqUVYH/1NHguvY1AMJONWKxZwskXmg DKU2Ri0WZSvI5NZ72yWExxE9wTe22vkkQN1FWQoLkr+5bnXwlIgSy5DXS3JbJTbr nFOAxH6HmcK+pYEQZLxuHGk5jfeK7T8w69M5b55pz7nfYWs2pi4Z4klKteo+wogv LYUK+54SbovkjvcCJ6nB8u+yVF80IFfLO1vhPG991JjzmusaIHlD2/kbbQ9CjgHd vzn6MNeEIe5PZ+sx35kdg6cOOeZ4eX1lDW9tVxkZZnEyKPyvaX09De2pDdosQV+C psjoHWa0gQDGZ0CF6GfoEnc/nFx+ignvvzqOx47Ckaa/GiCx2oqD/YzYfhuizNU= =muZ6 -----END PGP SIGNATURE----- --------------enig801EA707EFE6620484B9B151--