From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKy9-0005J5-GO for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:29:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShKy4-0004RF-Gb for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:29:13 -0400 Received: from david.siemens.de ([192.35.17.14]:32004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShKy4-0004QM-6g for qemu-devel@nongnu.org; Wed, 20 Jun 2012 09:29:08 -0400 Message-ID: <4FE1D015.2060803@siemens.com> Date: Wed, 20 Jun 2012 15:28:53 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1340197164-9574-1-git-send-email-imammedo@redhat.com> <1340197164-9574-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1340197164-9574-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] target-i386: drop usage of prev_debug_excp_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: "peter.maydell@linaro.org" , "aliguori@us.ibm.com" , "ehabkost@redhat.com" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "mdroth@linux.vnet.ibm.com" , "blauwirbel@gmail.com" , "avi@redhat.com" , "pbonzini@redhat.com" , "afaerber@suse.de" On 2012-06-20 14:59, Igor Mammedov wrote: > Chain of exception handlers are currently unused feature, drop it > for now to avoid moving prev_debug_excp_handler variable at global > scope when moving tcg initialization into target-i386/cpu.c > > Later we probably could re-invent better interface for this. > > Signed-off-by: Igor Mammedov > --- > target-i386/helper.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index 2cc8097..b9384f6 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -941,8 +941,6 @@ int check_hw_breakpoints(CPUX86State *env, int force_dr6_update) > return hit_enabled; > } > > -static CPUDebugExcpHandler *prev_debug_excp_handler; > - > static void breakpoint_handler(CPUX86State *env) > { > CPUBreakpoint *bp; > @@ -965,8 +963,6 @@ static void breakpoint_handler(CPUX86State *env) > break; > } > } > - if (prev_debug_excp_handler) > - prev_debug_excp_handler(env); > } > > typedef struct MCEInjectionParams { > @@ -1166,8 +1162,7 @@ X86CPU *cpu_x86_init(const char *cpu_model) > inited = 1; > optimize_flags_init(); > #ifndef CONFIG_USER_ONLY > - prev_debug_excp_handler = > - cpu_set_debug_excp_handler(breakpoint_handler); > + cpu_set_debug_excp_handler(breakpoint_handler); > #endif > } > if (cpu_x86_register(cpu, cpu_model) < 0) { > That's inconsistent. Let's remove this for all targets and drop the return value of cpu_set_debug_excp_handler. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux