* [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory
@ 2012-06-20 13:54 Peter Maydell
2012-06-20 13:56 ` Peter Maydell
2012-06-20 13:58 ` Andreas Färber
0 siblings, 2 replies; 5+ messages in thread
From: Peter Maydell @ 2012-06-20 13:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Andreas Färber, Anthony Liguori
Now we create object files in a hierarchy under hw/, so the
'clean' target must also updated to delete those object files.
Rather than using a manual list of subdirectories which will
easily drift out of date, we just delete all .o and .d files
in the target directory hierarchy.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Makefile.target | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 550d889..686ba8d 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -193,8 +193,8 @@ qmp-commands-old.h: $(SRC_PATH)/qmp-commands.hx
$(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
clean:
- rm -f *.o *.a *~ $(PROGS) nwfpe/*.o fpu/*.o
- rm -f *.d */*.d tcg/*.o ide/*.o 9pfs/*.o kvm/*.o
+ rm -f *.a *~ $(PROGS)
+ rm $(shell find . -name '*.[od]')
rm -f hmp-commands.h qmp-commands-old.h gdbstub-xml.c
ifdef CONFIG_TRACE_SYSTEMTAP
rm -f *.stp
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory
2012-06-20 13:54 [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory Peter Maydell
@ 2012-06-20 13:56 ` Peter Maydell
2012-06-20 13:58 ` Andreas Färber
1 sibling, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-06-20 13:56 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Andreas Färber, Anthony Liguori
On 20 June 2012 14:54, Peter Maydell <peter.maydell@linaro.org> wrote:
> Now we create object files in a hierarchy under hw/, so the
> 'clean' target must also updated to delete those object files.
> Rather than using a manual list of subdirectories which will
> easily drift out of date, we just delete all .o and .d files
> in the target directory hierarchy.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Makefile.target | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 550d889..686ba8d 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -193,8 +193,8 @@ qmp-commands-old.h: $(SRC_PATH)/qmp-commands.hx
> $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
>
> clean:
> - rm -f *.o *.a *~ $(PROGS) nwfpe/*.o fpu/*.o
> - rm -f *.d */*.d tcg/*.o ide/*.o 9pfs/*.o kvm/*.o
> + rm -f *.a *~ $(PROGS)
> + rm $(shell find . -name '*.[od]')
Forgot the '-f', doh. I'll repost later if nobody complains that
the whole approach is a dumb idea.
> rm -f hmp-commands.h qmp-commands-old.h gdbstub-xml.c
> ifdef CONFIG_TRACE_SYSTEMTAP
> rm -f *.stp
> --
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory
2012-06-20 13:54 [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory Peter Maydell
2012-06-20 13:56 ` Peter Maydell
@ 2012-06-20 13:58 ` Andreas Färber
1 sibling, 0 replies; 5+ messages in thread
From: Andreas Färber @ 2012-06-20 13:58 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, qemu-devel, Anthony Liguori
Am 20.06.2012 15:54, schrieb Peter Maydell:
> Now we create object files in a hierarchy under hw/, so the
> 'clean' target must also updated to delete those object files.
"be updated"
Other than that and the -f looks good. Thanks.
/-F
> Rather than using a manual list of subdirectories which will
> easily drift out of date, we just delete all .o and .d files
> in the target directory hierarchy.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Makefile.target | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 550d889..686ba8d 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -193,8 +193,8 @@ qmp-commands-old.h: $(SRC_PATH)/qmp-commands.hx
> $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
>
> clean:
> - rm -f *.o *.a *~ $(PROGS) nwfpe/*.o fpu/*.o
> - rm -f *.d */*.d tcg/*.o ide/*.o 9pfs/*.o kvm/*.o
> + rm -f *.a *~ $(PROGS)
> + rm $(shell find . -name '*.[od]')
> rm -f hmp-commands.h qmp-commands-old.h gdbstub-xml.c
> ifdef CONFIG_TRACE_SYSTEMTAP
> rm -f *.stp
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory
@ 2012-06-20 17:02 Peter Maydell
2012-06-20 17:13 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Peter Maydell @ 2012-06-20 17:02 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Andreas Färber, Anthony Liguori, patches
Now we create object files in a hierarchy under hw/, so the
'clean' target must also be updated to delete those object files.
Rather than using a manual list of subdirectories which will
easily drift out of date, we just delete all .o and .d files
in the target directory hierarchy.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
v1->v2: fixed missing "-f" option to rm, fixed grammar flub
in commit message.
Makefile.target | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.target b/Makefile.target
index 550d889..6d60050 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -193,8 +193,8 @@ qmp-commands-old.h: $(SRC_PATH)/qmp-commands.hx
$(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
clean:
- rm -f *.o *.a *~ $(PROGS) nwfpe/*.o fpu/*.o
- rm -f *.d */*.d tcg/*.o ide/*.o 9pfs/*.o kvm/*.o
+ rm -f *.a *~ $(PROGS)
+ rm -f $(shell find . -name '*.[od]')
rm -f hmp-commands.h qmp-commands-old.h gdbstub-xml.c
ifdef CONFIG_TRACE_SYSTEMTAP
rm -f *.stp
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory
2012-06-20 17:02 Peter Maydell
@ 2012-06-20 17:13 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2012-06-20 17:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Andreas Färber, Anthony Liguori, patches
This is v2, obviously -- I forgot to change the [PATCH] prefix :-(
-- PMM
On 20 June 2012 18:02, Peter Maydell <peter.maydell@linaro.org> wrote:
> Now we create object files in a hierarchy under hw/, so the
> 'clean' target must also be updated to delete those object files.
> Rather than using a manual list of subdirectories which will
> easily drift out of date, we just delete all .o and .d files
> in the target directory hierarchy.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2: fixed missing "-f" option to rm, fixed grammar flub
> in commit message.
>
> Makefile.target | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 550d889..6d60050 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -193,8 +193,8 @@ qmp-commands-old.h: $(SRC_PATH)/qmp-commands.hx
> $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
>
> clean:
> - rm -f *.o *.a *~ $(PROGS) nwfpe/*.o fpu/*.o
> - rm -f *.d */*.d tcg/*.o ide/*.o 9pfs/*.o kvm/*.o
> + rm -f *.a *~ $(PROGS)
> + rm -f $(shell find . -name '*.[od]')
> rm -f hmp-commands.h qmp-commands-old.h gdbstub-xml.c
> ifdef CONFIG_TRACE_SYSTEMTAP
> rm -f *.stp
> --
> 1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-06-20 17:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-20 13:54 [Qemu-devel] [PATCH] Makefile.target: Update clean command to clean hw/ directory Peter Maydell
2012-06-20 13:56 ` Peter Maydell
2012-06-20 13:58 ` Andreas Färber
-- strict thread matches above, loose matches on Subject: below --
2012-06-20 17:02 Peter Maydell
2012-06-20 17:13 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).