From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShMSO-0001w4-LG
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:04:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShMSE-0003jv-Ki
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:04:32 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56902 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShMSE-0003jb-EE
	for qemu-devel@nongnu.org; Wed, 20 Jun 2012 11:04:22 -0400
Message-ID: <4FE1E672.9080309@suse.de>
Date: Wed, 20 Jun 2012 17:04:18 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1340203444-20394-1-git-send-email-aliguori@us.ibm.com>
	<4FE1E355.3010102@suse.de>
	<CAFEAcA__PhiiFJXYu-49UsUtd7VfnkpS8NsFZiFqJugPJuma2w@mail.gmail.com>
In-Reply-To: <CAFEAcA__PhiiFJXYu-49UsUtd7VfnkpS8NsFZiFqJugPJuma2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables
 and use them for kvm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 20.06.2012 17:01, schrieb Peter Maydell:
> On 20 June 2012 15:51, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Am 20.06.2012 16:44, schrieb Anthony Liguori:
>>> --- a/hw/kvm/Makefile.objs
>>> +++ b/hw/kvm/Makefile.objs
>>> @@ -1 +1 @@
>>> -obj-$(CONFIG_KVM) +=3D clock.o apic.o i8259.o ioapic.o i8254.o
>>> +obj-$(CONFIG_I386) +=3D clock.o apic.o i8259.o ioapic.o i8254.o
>>
>> NACK. As long as the CPUState conversion is not completed (which after
>> part 4 will take some time still) any user of CPUArchState must be
>> compiled per target, not per base target.
>=20
> I'm confused -- as far as I can tell these files are compiled per
> target, eg we have both
>   CC    i386-softmmu/hw/kvm/clock.o
> and
>   CC    x86_64-softmmu/hw/kvm/clock.o

Currently yes, but with this patch Anthony seems to be changing this to
build in libhwX, no? Cf. hw/Makefile.objs.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg