From: Anthony Liguori <aliguori@us.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm
Date: Wed, 20 Jun 2012 10:20:49 -0500 [thread overview]
Message-ID: <4FE1EA51.2080809@us.ibm.com> (raw)
In-Reply-To: <4FE1E355.3010102@suse.de>
On 06/20/2012 09:51 AM, Andreas Färber wrote:
> Am 20.06.2012 16:44, schrieb Anthony Liguori:
>> diff --git a/hw/kvm/Makefile.objs b/hw/kvm/Makefile.objs
>> index 226497a..cf734ba 100644
>> --- a/hw/kvm/Makefile.objs
>> +++ b/hw/kvm/Makefile.objs
>> @@ -1 +1 @@
>> -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic.o i8254.o
>> +obj-$(CONFIG_I386) += clock.o apic.o i8259.o ioapic.o i8254.o
>
> NACK. As long as the CPUState conversion is not completed (which after
> part 4 will take some time still) any user of CPUArchState must be
> compiled per target, not per base target. It may or may not work
> depending on fields accessed, but it is architecturally wrong.
It's admittedly confusing.
obj-y => this is built per-target (there is no concept of per-base target)
hw-obj-y => this is built once for 32-bit, once for 64-bit
common-obj-y => this is built once for all targets
CONFIG_I386=y if target arch == i386 or base arch == i386.
Regards.
Anthony Liguori
>
> Andreas
>
next prev parent reply other threads:[~2012-06-20 15:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 14:44 [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm Anthony Liguori
2012-06-20 14:51 ` Andreas Färber
2012-06-20 15:01 ` Peter Maydell
2012-06-20 15:04 ` Andreas Färber
2012-06-20 15:07 ` Peter Maydell
2012-06-20 15:23 ` Andreas Färber
2012-06-20 15:20 ` Anthony Liguori [this message]
2012-06-20 15:09 ` Peter Maydell
[not found] ` <CAFEAcA-MgQuEfca7bPtUrN-wwN0KVCvXWpcs8Y4tdWL+CbcGFw@mail.gmail.com>
[not found] ` <4FEDA01B.8010502@suse.de>
2012-07-01 14:10 ` Paolo Bonzini
[not found] ` <4FEDB5F0.1070407@codemonkey.ws>
2012-07-23 14:21 ` Peter Maydell
2012-07-31 17:28 ` Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2012-06-21 12:31 Paolo Bonzini
2012-06-21 13:06 ` Anthony Liguori
2012-06-23 7:53 ` Paolo Bonzini
2012-06-23 10:30 ` Peter Maydell
2012-07-01 13:37 ` Paolo Bonzini
2012-07-01 13:49 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE1EA51.2080809@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).