From: Gerd Hoffmann <kraxel@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server
Date: Thu, 21 Jun 2012 12:23:48 +0200 [thread overview]
Message-ID: <4FE2F634.7060101@redhat.com> (raw)
In-Reply-To: <20120621095927.GI21124@redhat.com>
On 06/21/12 11:59, Daniel P. Berrange wrote:
> On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote:
>> 20.06.2012 16:24, Daniel P. Berrange wrote:
>>> delete mode 100644 ui/vnc-jobs-async.c
>>> delete mode 100644 ui/vnc-jobs-sync.c
>>> create mode 100644 ui/vnc-jobs.c
>>
>> Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ?
>
> The corresponding header file is vnc-jobs.h, and since we only
> have one impl of it now, using the same name is normal practice.
>
>> I'd leave it alone at this stage, omiting just the rename...
>
> I disagree, GIT handles renames like this fine, so there's no
> reason not to do this.
/me suggests "git format-patch -M" so the patch shows the rename.
cheers,
Gerd
prev parent reply other threads:[~2012-06-21 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 13:24 [Qemu-devel] [PATCH] Remove support for non-threaded VNC server Daniel P. Berrange
2012-06-21 9:57 ` Michael Tokarev
2012-06-21 9:59 ` Daniel P. Berrange
2012-06-21 10:23 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE2F634.7060101@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=berrange@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).