From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SheYQ-0003Xr-Ug for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:24:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SheYK-0004Wy-Ns for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:23:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SheYK-0004Wr-Fm for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:23:52 -0400 Message-ID: <4FE2F634.7060101@redhat.com> Date: Thu, 21 Jun 2012 12:23:48 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <1340198668-21307-1-git-send-email-berrange@redhat.com> <4FE2F018.60109@msgid.tls.msk.ru> <20120621095927.GI21124@redhat.com> In-Reply-To: <20120621095927.GI21124@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Anthony Liguori , Michael Tokarev , qemu-devel@nongnu.org On 06/21/12 11:59, Daniel P. Berrange wrote: > On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote: >> 20.06.2012 16:24, Daniel P. Berrange wrote: >>> delete mode 100644 ui/vnc-jobs-async.c >>> delete mode 100644 ui/vnc-jobs-sync.c >>> create mode 100644 ui/vnc-jobs.c >> >> Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ? > > The corresponding header file is vnc-jobs.h, and since we only > have one impl of it now, using the same name is normal practice. > >> I'd leave it alone at this stage, omiting just the rename... > > I disagree, GIT handles renames like this fine, so there's no > reason not to do this. /me suggests "git format-patch -M" so the patch shows the rename. cheers, Gerd