From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShekL-0000IW-IU
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:36:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShekF-0007vc-Tm
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:36:17 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43762 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ShekF-0007vO-F7
	for qemu-devel@nongnu.org; Thu, 21 Jun 2012 06:36:11 -0400
Message-ID: <4FE2F912.1080904@suse.de>
Date: Thu, 21 Jun 2012 12:36:02 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <4FE29366.6050101@ozlabs.ru>
In-Reply-To: <4FE29366.6050101@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] hw/Makefile.objs question
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Am 21.06.2012 05:22, schrieb Alexey Kardashevskiy:
> I am trying to compile the very last qemu with vfio_pci enabled. VFIO_P=
CI is added as below:
>=20
> ./configure:
>=20
>  case "$target_arch2" in
>   i386|x86_64|ppc64)
>      if test "$vfio_pci" =3D "yes" -a "$target_softmmu" =3D "yes" ; the=
n
>        echo "CONFIG_VFIO_PCI=3Dy" >> $config_target_mak
>      fi
>  esac
>=20
>=20
> ./Makefile.target:
>=20
>  # VFIO PCI device assignment
> obj-$(CONFIG_VFIO_PCI) +=3D vfio_pci.o
>=20
>=20
> And it worked before. However it does not anymore as it seems that ever=
ything in hw/ (and vfio_pci.c
> as well as is in hw/ and it is a device) can be only compiled via hw/Ma=
kefile.objs and
> hw/ppc/Makefile.objs (my platform is POWER), it is ignored if to keep i=
t as is.
>=20
> So I have to move "obj-$(CONFIG_VFIO_PCI) +=3D vfio_pci.o" to hw/Makefi=
le.objs (and change obj- to
> hw-obj-) but the hw/Makefile.objs does not include (directly or indirec=
tly) generated
> ppc64-softmmu/config-target.mak with CONFIG_VFIO_PCI=3Dy.
>=20
> What is the correct solution?

If the file compiles the same for all three, put CONFIG_VFIO_PCI=3Dy into
default-configs/{i386,x86_64,ppc64}-softmmu.mak and do
hw-obj-$(CONFIG_VFIO_PCI) +=3D in hw/Makefile.objs.

Otherwise, add to hw/{i386,ppc}/Makefile.objs - or with Anthony's
proposal from yesterday hw/Makefile.objs becomes possible, too.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg