From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShfS5-000882-0D for qemu-devel@nongnu.org; Thu, 21 Jun 2012 07:21:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ShfRv-0001Cm-6j for qemu-devel@nongnu.org; Thu, 21 Jun 2012 07:21:28 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:40172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ShfRv-0001CP-0E for qemu-devel@nongnu.org; Thu, 21 Jun 2012 07:21:19 -0400 Received: by dadn2 with SMTP id n2so762628dad.4 for ; Thu, 21 Jun 2012 04:21:16 -0700 (PDT) Message-ID: <4FE303A9.9010308@ozlabs.ru> Date: Thu, 21 Jun 2012 21:21:13 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <4FE29366.6050101@ozlabs.ru> <4FE2F912.1080904@suse.de> In-Reply-To: <4FE2F912.1080904@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] hw/Makefile.objs question List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Paolo Bonzini , Alex Williamson , qemu-devel@nongnu.org, Anthony Liguori On 21/06/12 20:36, Andreas Färber wrote: > Am 21.06.2012 05:22, schrieb Alexey Kardashevskiy: >> I am trying to compile the very last qemu with vfio_pci enabled. VFIO_PCI is added as below: >> >> ./configure: >> >> case "$target_arch2" in >> i386|x86_64|ppc64) >> if test "$vfio_pci" = "yes" -a "$target_softmmu" = "yes" ; then >> echo "CONFIG_VFIO_PCI=y" >> $config_target_mak >> fi >> esac >> >> >> ./Makefile.target: >> >> # VFIO PCI device assignment >> obj-$(CONFIG_VFIO_PCI) += vfio_pci.o >> >> >> And it worked before. However it does not anymore as it seems that everything in hw/ (and vfio_pci.c >> as well as is in hw/ and it is a device) can be only compiled via hw/Makefile.objs and >> hw/ppc/Makefile.objs (my platform is POWER), it is ignored if to keep it as is. >> >> So I have to move "obj-$(CONFIG_VFIO_PCI) += vfio_pci.o" to hw/Makefile.objs (and change obj- to >> hw-obj-) but the hw/Makefile.objs does not include (directly or indirectly) generated >> ppc64-softmmu/config-target.mak with CONFIG_VFIO_PCI=y. >> >> What is the correct solution? > > If the file compiles the same for all three, put CONFIG_VFIO_PCI=y into > default-configs/{i386,x86_64,ppc64}-softmmu.mak and do > hw-obj-$(CONFIG_VFIO_PCI) += in hw/Makefile.objs. It only compiles with ./configure --enable-vfio-pci which may or may not set CONFIG_VFIO_PCI to "y". Your proposal makes it always "y" (for selected platforms). > Otherwise, add to hw/{i386,ppc}/Makefile.objs - or with Anthony's > proposal from yesterday hw/Makefile.objs becomes possible, too. Again, it will be unconditional "y". -- Alexey