Re: [Qemu-devel] [PATCH 2/2] cpu-common.h: Remove a pointless ifndef CONFIG_USER_ONLY

["Andreas Färber" <afaerber@suse.de>]

Am 22.06.2012 13:30, schrieb Peter Maydell:
> Remove an ifndef CONFIG_USER_ONLY guard that was pointless
> because it is already inside an if !defined(CONFIG_USER_ONLY).
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  cpu-common.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/cpu-common.h b/cpu-common.h
> index 321037f..85548de 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -69,9 +69,7 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
>  void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
>  void cpu_unregister_map_client(void *cookie);
>  
> -#ifndef CONFIG_USER_ONLY
>  bool cpu_physical_memory_is_io(target_phys_addr_t phys_addr);
> -#endif
>  
>  /* Coalesced MMIO regions are areas where write operations can be reordered.
>   * This usually implies that write operations are side-effect free.  This allows

Acked-by: Andreas Färber <afaerber@suse.de>

Spotted that yesterday myself and was planning to send a patch. :)

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg