From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlGdG-0007h2-5R for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:39:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlGdA-00070o-UY for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:39:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlGdA-00070e-MD for qemu-devel@nongnu.org; Sun, 01 Jul 2012 05:39:48 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q619dlhw022989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 1 Jul 2012 05:39:48 -0400 Message-ID: <4FF01AF1.4080106@redhat.com> Date: Sun, 01 Jul 2012 12:40:01 +0300 From: Orit Wasserman MIME-Version: 1.0 References: <704b60a0d2b32fbf6bf229b115082c2b929a4731.1340910651.git.quintela@redhat.com> In-Reply-To: <704b60a0d2b32fbf6bf229b115082c2b929a4731.1340910651.git.quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/12] savevm: remove SaveSetParamsHandler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 06/28/2012 10:22 PM, Juan Quintela wrote: > It was used only once, just unfold. > > Signed-off-by: Juan Quintela > --- > vmstate.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/vmstate.h b/vmstate.h > index 4bce53b..5e1a7cc 100644 > --- a/vmstate.h > +++ b/vmstate.h > @@ -26,13 +26,12 @@ > #ifndef QEMU_VMSTATE_H > #define QEMU_VMSTATE_H 1 > > -typedef void SaveSetParamsHandler(const MigrationParams *params, void * opaque); > typedef void SaveStateHandler(QEMUFile *f, void *opaque); > typedef int SaveLiveStateHandler(QEMUFile *f, int stage, void *opaque); > typedef int LoadStateHandler(QEMUFile *f, void *opaque, int version_id); > > typedef struct SaveVMHandlers { > - SaveSetParamsHandler *set_params; > + void (*set_params)(const MigrationParams *params, void * opaque); > SaveStateHandler *save_state; > SaveLiveStateHandler *save_live_state; > LoadStateHandler *load_state; > Reviewed-by: Orit Wasserman