From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlKHA-0001xp-SG for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:33:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlKH8-00024p-KK for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:33:20 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:33382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlKH8-00024C-Bw for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:33:18 -0400 Received: by wgbfm10 with SMTP id fm10so4057779wgb.10 for ; Sun, 01 Jul 2012 06:33:16 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FF05199.2090305@redhat.com> Date: Sun, 01 Jul 2012 15:33:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1339575768-2557-1-git-send-email-lersek@redhat.com> <4FD8716C.3030503@redhat.com> In-Reply-To: <4FD8716C.3030503@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Laszlo Ersek , qemu-devel@nongnu.org Il 13/06/2012 12:54, Paolo Bonzini ha scritto: > Il 13/06/2012 10:22, Laszlo Ersek ha scritto: >> Inspired by [1], the first half of this series attempts to implement a new >> visitor that should clean up defining and processing command line options. >> For a more detailed description, please see "[PATCH 05/17] qapi: introduce >> OptsVisitor". >> >> The second half converts -net/-netdev parsing to the new visitor. >> >> v1->v2: >> - Insert a small patch between v1 01/16 and v1 02/16 in order to generate >> C types for fixed-width integers. >> - Tighten / clean up integer types in Netdev options and in OptsVisitor. >> - NetLegacy::name is optional. >> - Changes are marked below individually and described separately. >> - (Rebase to current master.) > > Looks good, thanks! Luiz, what's the state of this? Paolo