From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlKKL-0002pT-5X for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlKKJ-0003Go-MP for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:36:36 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlKKJ-0003Ge-CS for qemu-devel@nongnu.org; Sun, 01 Jul 2012 09:36:35 -0400 Received: by wibhm2 with SMTP id hm2so1962671wib.10 for ; Sun, 01 Jul 2012 06:36:33 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FF0525F.3000200@redhat.com> Date: Sun, 01 Jul 2012 15:36:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1340196107-6309-1-git-send-email-kraxel@redhat.com> <1340196107-6309-4-git-send-email-kraxel@redhat.com> In-Reply-To: <1340196107-6309-4-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Il 20/06/2012 14:41, Gerd Hoffmann ha scritto: > Special thanks go to Paolo for bringing the qemu scsi emulation into > shape, so this can be added nicely without having to touch a single line > of scsi code. But we can touch it and make it even better. :) Do you need a release_req SCSIBusInfo method that is called with the hba_private when a request refcount goes to zero, so that you can remove usb_uas_ref_request and usb_uas_unref_request? (and replace it with scsi_req_ref/unref in usb_uas_handle_data, I think). Paolo