From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlcbD-0004Dp-Rq for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:07:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slcb3-00068x-W9 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:07:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slcb3-00068g-Ol for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:07:05 -0400 Message-ID: <4FF164B4.50306@redhat.com> Date: Mon, 02 Jul 2012 12:07:00 +0300 From: Avi Kivity MIME-Version: 1.0 References: <35d20ce2ae928e21ff715c86f854860d164ff8c9.1340814444.git.jan.kiszka@siemens.com> <4FEC814C.9040808@redhat.com> <4FEDD9E7.9040702@siemens.com> In-Reply-To: <4FEDD9E7.9040702@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/7] memory: Flush coalesced MMIO on selected region access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Liu Ping Fan , qemu-devel , kvm , Marcelo Tosatti On 06/29/2012 07:37 PM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also applied to other regions, e.g. > of the same device, by calling memory_region_set_flush_coalesced. Looks fine. I have a hard time deciding whether this should go through the kvm tree or memory tree. Anthony, perhaps you can commit it directly to avoid the livelock? Reviewed-by: Avi Kivity -- error compiling committee.c: too many arguments to function