From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sld4x-0001zK-RG for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:38:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sld4v-0005Uz-Rs for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:37:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sld4v-0005Uk-Jq for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:37:57 -0400 Message-ID: <4FF16BF0.7010905@redhat.com> Date: Mon, 02 Jul 2012 11:37:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1340610940-923-1-git-send-email-o.ogurtsov@samsung.com> <1340610940-923-2-git-send-email-o.ogurtsov@samsung.com> <4FE82E60.5050007@suse.de> <4FE84FAE.1050709@samsung.com> <4FE852F7.9060405@suse.de> <4FE92A16.5060705@samsung.com> <4FED9EFA.8040402@suse.de> <4FF06C3C.2070706@redhat.com> <4FF164F5.90302@samsung.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Exynos4: added RTC device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Igor Mitsyanko , Evgeny Voevodin , qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, Oleg Ogurtsov , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= Il 02/07/2012 11:31, Peter Maydell ha scritto: > On 2 July 2012 10:08, Igor Mitsyanko wrote: >> So, what's the consensus here, for now new devices go to >> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >> devices (not just exynos-related) from hw/arm/Makefile.objs to >> hw/Makefile.objs with one commit? Because having one RTC device compile >> through hw/Makefile.objs while all other exynos devices are compiled through >> hw/arm/Makefile.objs doesn't makes much sense. > > I don't want things moved piecemeal, especially not one file from > a whole board model. > > I'd also like to see a nice clear summary of the ground rules first > (ie how you decide which makefile / target / whatever a file should > be in). At the moment I'm not really sure what the rules are, which > means I can't properly review those bits of patches. For now nothing should change compared to the past, except that obj-y should appear in hw/ARCH/Makefile.objs rather than Makefile.target. This is because there is still no mechanism to guard the build of ARM-only devices from hw/Makefile.objs. When Anthony's patch lands, we can start moving files to hw/Makefile.objs using CONFIG_ARCH_ARM; I understood Andreas is going to do that. For new boards, you may want to request a new CONFIG_* symbol (e.g. CONFIG_EXYNOS) so that new boards can already compile their devices from hw/Makefile.objs. However, that's up to you and definitely shouldn't be done for one file from a whole board model, as you said. Paolo