From: Paolo Bonzini <pbonzini@redhat.com>
To: bharata@linux.vnet.ibm.com
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Amar Tumballi <amarts@redhat.com>,
qemu-devel@nongnu.org, Vijay Bellur <vbellur@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs
Date: Mon, 02 Jul 2012 11:52:04 +0200 [thread overview]
Message-ID: <4FF16F44.2040303@redhat.com> (raw)
In-Reply-To: <20120619093116.GD27963@in.ibm.com>
Il 19/06/2012 11:31, Bharata B Rao ha scritto:
>>> > > + ret = pthread_create(&thread, NULL, gluster_handle_poll,
>>> > > + (void *)gctx);
>> >
>> > Please use qemu-thread.h. QEMU uses signals so you almost certainly
>> > want to mask signals for this thread (qemu_thread_create() does that).
> Ok. This is temporary since this entire patch (2/3) would be redundant
> when we have libglusterfsclient working.
Please make sure that libglusterfsclient also masks signals for its own
threads. It's a pretty common source of bugs with threaded libraries,
and masking the signals is harmless for programs that do not care.
Paolo
next prev parent reply other threads:[~2012-07-02 9:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:18 [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU Bharata B Rao
2012-06-11 14:19 ` [Qemu-devel] [RFC PATCH 1/3] qemu: Add a config option for GlusterFS as block backend Bharata B Rao
2012-06-11 14:20 ` [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs Bharata B Rao
2012-06-18 17:35 ` Stefan Hajnoczi
2012-06-19 9:31 ` Bharata B Rao
2012-07-02 9:52 ` Paolo Bonzini [this message]
2012-07-02 10:05 ` Bharata B Rao
2012-06-11 14:21 ` [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend Bharata B Rao
2012-06-18 17:35 ` Stefan Hajnoczi
2012-06-19 9:27 ` Avi Kivity
2012-06-19 9:30 ` Bharata B Rao
2012-06-19 11:05 ` Stefan Hajnoczi
2012-07-01 14:50 ` Paolo Bonzini
2012-07-01 14:49 ` Paolo Bonzini
2012-06-18 15:36 ` [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU Stefan Hajnoczi
2012-06-19 9:10 ` Bharata B Rao
2012-07-06 5:35 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF16F44.2040303@redhat.com \
--to=pbonzini@redhat.com \
--cc=amarts@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vbellur@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).