From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SldIn-0001PY-4s for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:52:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SldIh-0000pT-0E for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:52:16 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SldIg-0000pD-O0 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 05:52:10 -0400 Received: by wibhm2 with SMTP id hm2so2432857wib.10 for ; Mon, 02 Jul 2012 02:52:08 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FF16F44.2040303@redhat.com> Date: Mon, 02 Jul 2012 11:52:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20120611141806.GA2737@in.ibm.com> <20120611142026.GC2737@in.ibm.com> <20120619093116.GD27963@in.ibm.com> In-Reply-To: <20120619093116.GD27963@in.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: bharata@linux.vnet.ibm.com Cc: Stefan Hajnoczi , Amar Tumballi , qemu-devel@nongnu.org, Vijay Bellur Il 19/06/2012 11:31, Bharata B Rao ha scritto: >>> > > + ret = pthread_create(&thread, NULL, gluster_handle_poll, >>> > > + (void *)gctx); >> > >> > Please use qemu-thread.h. QEMU uses signals so you almost certainly >> > want to mask signals for this thread (qemu_thread_create() does that). > Ok. This is temporary since this entire patch (2/3) would be redundant > when we have libglusterfsclient working. Please make sure that libglusterfsclient also masks signals for its own threads. It's a pretty common source of bugs with threaded libraries, and masking the signals is harmless for programs that do not care. Paolo