From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SleUH-0002zV-0T for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:08:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SleUB-0003FL-NJ for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:08:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SleUB-0003FD-Ew for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:08:07 -0400 Message-ID: <4FF18113.4080403@redhat.com> Date: Mon, 02 Jul 2012 13:08:03 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: <4FEDD75A.1010705@siemens.com> In-Reply-To: <4FEDD75A.1010705@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Erik Rull , qemu-devel On 06/29/12 18:27, Jan Kiszka wrote: > Due to queuing/pipelining, there can now be multiple packets per > endpoint in flight. So the assertion in usb_packet_complete became wrong > and can cause bogus QEMU terminations. Seen with a passed-through USB > headset. NAK. The assert doesn't protect against multiple packets in flight, but against packet reorderng. Need to understand why to assert actually triggers. cheers, Gerd