From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation
Date: Mon, 02 Jul 2012 13:20:03 +0200 [thread overview]
Message-ID: <4FF183E3.9080509@redhat.com> (raw)
In-Reply-To: <4FF0525F.3000200@redhat.com>
On 07/01/12 15:36, Paolo Bonzini wrote:
> Il 20/06/2012 14:41, Gerd Hoffmann ha scritto:
>> Special thanks go to Paolo for bringing the qemu scsi emulation into
>> shape, so this can be added nicely without having to touch a single line
>> of scsi code.
>
> But we can touch it and make it even better. :)
>
> Do you need a release_req SCSIBusInfo method that is called with the
> hba_private when a request refcount goes to zero, so that you can remove
> usb_uas_ref_request and usb_uas_unref_request? (and replace it with
> scsi_req_ref/unref in usb_uas_handle_data, I think).
Good idea. Yes, that would indeed remove the need to do my own
reference counting.
cheers,
Gerd
next prev parent reply other threads:[~2012-07-02 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 12:41 [Qemu-devel] [PATCH 0/4] usb attached scsi Gerd Hoffmann
2012-06-20 12:41 ` [Qemu-devel] [PATCH 1/4] ehci: fix ehci_qh_do_overlay Gerd Hoffmann
2012-06-20 12:41 ` [Qemu-devel] [PATCH 2/4] ehci: fix td writeback Gerd Hoffmann
2012-06-20 12:41 ` [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation Gerd Hoffmann
2012-07-01 13:36 ` Paolo Bonzini
2012-07-02 11:20 ` Gerd Hoffmann [this message]
2012-06-20 12:41 ` [Qemu-devel] [PATCH 4/4] [wip] ehci: don't flush cache on dorbell rings Gerd Hoffmann
2012-06-21 9:28 ` Gerd Hoffmann
2012-06-21 10:04 ` Peter Maydell
2012-06-21 10:27 ` Andreas Färber
2012-06-21 11:28 ` Dor Laor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF183E3.9080509@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).