From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Slefp-0003dj-6f
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:20:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Slefn-0006Sx-G2
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:20:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2082)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Slefn-0006Rm-6w
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:20:07 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q62BK6B0020993
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 2 Jul 2012 07:20:06 -0400
Message-ID: <4FF183E3.9080509@redhat.com>
Date: Mon, 02 Jul 2012 13:20:03 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1340196107-6309-1-git-send-email-kraxel@redhat.com>
	<1340196107-6309-4-git-send-email-kraxel@redhat.com>
	<4FF0525F.3000200@redhat.com>
In-Reply-To: <4FF0525F.3000200@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/01/12 15:36, Paolo Bonzini wrote:
> Il 20/06/2012 14:41, Gerd Hoffmann ha scritto:
>> Special thanks go to Paolo for bringing the qemu scsi emulation into
>> shape, so this can be added nicely without having to touch a single line
>> of scsi code.
> 
> But we can touch it and make it even better. :)
> 
> Do you need a release_req SCSIBusInfo method that is called with the
> hba_private when a request refcount goes to zero, so that you can remove
> usb_uas_ref_request and usb_uas_unref_request?  (and replace it with
> scsi_req_ref/unref in usb_uas_handle_data, I think).

Good idea.  Yes, that would indeed remove the need to do my own
reference counting.

cheers,
  Gerd