From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlfFH-0004AC-6d for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:56:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlfFF-0007lV-5d for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:56:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34015 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlfFE-0007lB-S6 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 07:56:45 -0400 Message-ID: <4FF18C77.1070704@suse.de> Date: Mon, 02 Jul 2012 13:56:39 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH] Expose tsc deadline timer feature to guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Liu, Jinsong" Cc: Eduardo Habkost , kvm , Jan Kiszka , Marcelo Tosatti , "qemu-devel@nongnu.org" , Avi Kivity Am 02.07.2012 13:08, schrieb Liu, Jinsong: > Eduardo, Jan, Andreas >=20 > As we sync 3 months ago, I wait until qemu1.1 done, then re-write patch= based on qemu1.1. > Now it's time to re-write my patch based on qemu1.1. >=20 > Attached is a RFC patch for exposing tsc deadline timer to guest. > I have checked current qemu1.1 code, and read some emails regarding to = cpuid exposing these days. > However, I think I may ignore something (so many discussion :-), so if = you think anything wrong, please point out to me. No objections or nitpicks from my (CPU) side FWIW. Regards, Andreas >=20 > Thanks, > Jinsong >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > From 8b5b003f6f8834d2d5d71e18bb47b7f089bc4928 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Tue, 3 Jul 2012 02:35:10 +0800 > Subject: [PATCH] Expose tsc deadline timer feature to guest >=20 > This patch exposes tsc deadline timer feature to guest if > 1). in-kernel irqchip is used, and > 2). kvm has emulated tsc deadline timer, and > 3). user authorize the feature exposing via -cpu or +/- tsc-deadline >=20 > Signed-off-by: Liu, Jinsong > --- > target-i386/cpu.h | 1 + > target-i386/kvm.c | 5 +++++ > 2 files changed, 6 insertions(+), 0 deletions(-) >=20 > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index 79cc640..d1a4a04 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -400,6 +400,7 @@ > #define CPUID_EXT_X2APIC (1 << 21) > #define CPUID_EXT_MOVBE (1 << 22) > #define CPUID_EXT_POPCNT (1 << 23) > +#define CPUID_EXT_TSC_DEADLINE_TIMER (1 << 24) > #define CPUID_EXT_XSAVE (1 << 26) > #define CPUID_EXT_OSXSAVE (1 << 27) > #define CPUID_EXT_HYPERVISOR (1 << 31) > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 0d0d8f6..52b577f 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -361,8 +361,13 @@ int kvm_arch_init_vcpu(CPUX86State *env) > env->cpuid_features &=3D kvm_arch_get_supported_cpuid(s, 1, 0, R_E= DX); > =20 > i =3D env->cpuid_ext_features & CPUID_EXT_HYPERVISOR; > + j =3D env->cpuid_ext_features & CPUID_EXT_TSC_DEADLINE_TIMER; > env->cpuid_ext_features &=3D kvm_arch_get_supported_cpuid(s, 1, 0,= R_ECX); > env->cpuid_ext_features |=3D i; > + if (j && kvm_irqchip_in_kernel() && > + kvm_check_extension(s, KVM_CAP_TSC_DEADLINE_TIMER)) { > + env->cpuid_ext_features |=3D CPUID_EXT_TSC_DEADLINE_TIMER; > + } > =20 > env->cpuid_ext2_features &=3D kvm_arch_get_supported_cpuid(s, 0x80= 000001, > 0, R_EDX)= ; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg