From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
Evgeny Voevodin <e.voevodin@samsung.com>,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, Paolo Bonzini <pbonzini@redhat.com>,
Oleg Ogurtsov <o.ogurtsov@samsung.com>
Subject: Re: [Qemu-devel] [PATCH] Exynos4: added RTC device
Date: Mon, 02 Jul 2012 14:04:05 +0200 [thread overview]
Message-ID: <4FF18E35.8060305@suse.de> (raw)
In-Reply-To: <CAFEAcA_mOrFrxx0_UdA+wPksH41fyiS55C1_LjMDNM5RRFETsQ@mail.gmail.com>
Am 02.07.2012 11:31, schrieb Peter Maydell:
> On 2 July 2012 10:08, Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> So, what's the consensus here, for now new devices go to
>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific
>> devices (not just exynos-related) from hw/arm/Makefile.objs to
>> hw/Makefile.objs with one commit? Because having one RTC device compile
>> through hw/Makefile.objs while all other exynos devices are compiled through
>> hw/arm/Makefile.objs doesn't makes much sense.
>
> I don't want things moved piecemeal, especially not one file from
> a whole board model.
>
> I'd also like to see a nice clear summary of the ground rules first
> (ie how you decide which makefile / target / whatever a file should
> be in). At the moment I'm not really sure what the rules are, which
> means I can't properly review those bits of patches.
We've been through that like three times lately, not sure what's left to
discuss there?
There's two things to review in the migration we're discussing:
1) Are files compiled before the conversion still compiled afterwards?
2) Does the build break due to use of CPU or explicit swapping?
For new patches you should keep on eye on whether a new device really
must go into hw/arm/Makefile.objs or whether it can go in
hw/Makefile.objs instead. I.e., hw/Makefile.objs (libhwX/) should be the
rule for devices, not the exception. Machines today are tightly coupled
to the CPU and need to go into hw/arch/Makefile.objs always. Whether the
files get placed into hw/arch/ or hw/ is a matter of taste.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-02 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1340610940-923-1-git-send-email-o.ogurtsov@samsung.com>
[not found] ` <1340610940-923-2-git-send-email-o.ogurtsov@samsung.com>
[not found] ` <4FE82E60.5050007@suse.de>
[not found] ` <4FE84FAE.1050709@samsung.com>
[not found] ` <4FE852F7.9060405@suse.de>
[not found] ` <4FE92A16.5060705@samsung.com>
[not found] ` <4FED9EFA.8040402@suse.de>
2012-07-01 15:26 ` [Qemu-devel] [PATCH] Exynos4: added RTC device Paolo Bonzini
2012-07-02 9:08 ` Igor Mitsyanko
2012-07-02 9:31 ` Peter Maydell
2012-07-02 9:37 ` Paolo Bonzini
2012-07-02 9:42 ` Paolo Bonzini
2012-07-02 9:44 ` Peter Maydell
2012-07-02 9:46 ` Paolo Bonzini
2012-07-02 12:27 ` Andreas Färber
2012-07-02 12:04 ` Andreas Färber [this message]
2012-07-02 12:19 ` Peter Maydell
2012-07-02 11:44 ` Andreas Färber
2012-07-02 12:18 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF18E35.8060305@suse.de \
--to=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=o.ogurtsov@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).