From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SlfMX-0008QB-DB
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:04:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SlfMR-0001SD-It
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:04:16 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34854 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SlfMR-0001S9-9e
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:04:11 -0400
Message-ID: <4FF18E35.8060305@suse.de>
Date: Mon, 02 Jul 2012 14:04:05 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <o.ogurtsov@samsung.com>
	<1340610940-923-1-git-send-email-o.ogurtsov@samsung.com>
	<1340610940-923-2-git-send-email-o.ogurtsov@samsung.com>
	<4FE82E60.5050007@suse.de> <4FE84FAE.1050709@samsung.com>
	<4FE852F7.9060405@suse.de> <4FE92A16.5060705@samsung.com>
	<4FED9EFA.8040402@suse.de> <4FF06C3C.2070706@redhat.com>
	<4FF164F5.90302@samsung.com>
	<CAFEAcA_mOrFrxx0_UdA+wPksH41fyiS55C1_LjMDNM5RRFETsQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_mOrFrxx0_UdA+wPksH41fyiS55C1_LjMDNM5RRFETsQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Exynos4: added RTC device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>, Evgeny Voevodin <e.voevodin@samsung.com>, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, Paolo Bonzini <pbonzini@redhat.com>, Oleg Ogurtsov <o.ogurtsov@samsung.com>

Am 02.07.2012 11:31, schrieb Peter Maydell:
> On 2 July 2012 10:08, Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> So, what's the consensus here, for now new devices go to
>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-spec=
ific
>> devices (not just exynos-related) from hw/arm/Makefile.objs to
>> hw/Makefile.objs with one commit? Because having one RTC device compil=
e
>> through hw/Makefile.objs while all other exynos devices are compiled t=
hrough
>> hw/arm/Makefile.objs doesn't makes much sense.
>=20
> I don't want things moved piecemeal, especially not one file from
> a whole board model.
>=20
> I'd also like to see a nice clear summary of the ground rules first
> (ie how you decide which makefile / target / whatever a file should
> be in). At the moment I'm not really sure what the rules are, which
> means I can't properly review those bits of patches.

We've been through that like three times lately, not sure what's left to
discuss there?

There's two things to review in the migration we're discussing:
1) Are files compiled before the conversion still compiled afterwards?
2) Does the build break due to use of CPU or explicit swapping?

For new patches you should keep on eye on whether a new device really
must go into hw/arm/Makefile.objs or whether it can go in
hw/Makefile.objs instead. I.e., hw/Makefile.objs (libhwX/) should be the
rule for devices, not the exception. Machines today are tightly coupled
to the CPU and need to go into hw/arch/Makefile.objs always. Whether the
files get placed into hw/arch/ or hw/ is a matter of taste.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg