From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlfNL-0000jN-03 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:05:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlfNE-0001Vr-Ny for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:05:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlfNE-0001Vm-Fw for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:05:00 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q62C50Fm009925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Jul 2012 08:05:00 -0400 Message-ID: <4FF18E79.2000307@redhat.com> Date: Mon, 02 Jul 2012 15:05:13 +0300 From: Orit Wasserman MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 06/28/2012 10:22 PM, Juan Quintela wrote: > 1st: we were synchonizing the dirty bitmap before calling > memory_global_dirty_log_start(). > > 2nd: We are marking all pages as dirty anywhere, no reason to go > through all the bitmap to "mark" dirty same pages twice. > > So, call removed. > > Signed-off-by: Juan Quintela > --- > arch_init.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 8299c15..c1b4f13 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -308,8 +308,6 @@ static int ram_save_setup(QEMUFile *f, void *opaque) > ram_addr_t addr; > RAMBlock *block; > > - memory_global_sync_dirty_bitmap(get_system_memory()); > - > bytes_transferred = 0; > last_block = NULL; > last_offset = 0; > Reviewed-by: Orit Wasserman