From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slfiy-00010L-Gh for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slfir-00077a-3C for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:27:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36525 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slfiq-00077L-Q0 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:27:21 -0400 Message-ID: <4FF193A3.2000906@suse.de> Date: Mon, 02 Jul 2012 14:27:15 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1340610940-923-1-git-send-email-o.ogurtsov@samsung.com> <1340610940-923-2-git-send-email-o.ogurtsov@samsung.com> <4FE82E60.5050007@suse.de> <4FE84FAE.1050709@samsung.com> <4FE852F7.9060405@suse.de> <4FE92A16.5060705@samsung.com> <4FED9EFA.8040402@suse.de> <4FF06C3C.2070706@redhat.com> <4FF164F5.90302@samsung.com> <4FF16BF0.7010905@redhat.com> In-Reply-To: <4FF16BF0.7010905@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Exynos4: added RTC device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Igor Mitsyanko , Evgeny Voevodin , qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, Oleg Ogurtsov Am 02.07.2012 11:37, schrieb Paolo Bonzini: > Il 02/07/2012 11:31, Peter Maydell ha scritto: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-spe= cific >>> devices (not just exynos-related) from hw/arm/Makefile.objs to >>> hw/Makefile.objs with one commit? Because having one RTC device compi= le >>> through hw/Makefile.objs while all other exynos devices are compiled = through >>> hw/arm/Makefile.objs doesn't makes much sense. >> >> I don't want things moved piecemeal, especially not one file from >> a whole board model. >> >> I'd also like to see a nice clear summary of the ground rules first >> (ie how you decide which makefile / target / whatever a file should >> be in). At the moment I'm not really sure what the rules are, which >> means I can't properly review those bits of patches. >=20 > For now nothing should change compared to the past, except that obj-y > should appear in hw/ARCH/Makefile.objs rather than Makefile.target. > This is because there is still no mechanism to guard the build of > ARM-only devices from hw/Makefile.objs. When Anthony's patch lands, we > can start moving files to hw/Makefile.objs using CONFIG_ARCH_ARM; I > understood Andreas is going to do that. Not quite. What I started long before Anthony's patch is making devices (first Xilinx then ARM) less dependent on my CPU changes. That does not need CONFIG_[ARCH_]* in our current system. With armeb in mind I've gone for SoC-level and more fine-granular for generic devices. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg