From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Stefan Hajnoczi" <stefanha@linux.vnet.ibm.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "Amit Shah" <amit.shah@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool
Date: Mon, 02 Jul 2012 14:29:43 +0200 [thread overview]
Message-ID: <4FF19437.1070309@redhat.com> (raw)
In-Reply-To: <4FE8DFD7.2070307@us.ibm.com>
Il 26/06/2012 00:01, Anthony Liguori ha scritto:
> The various object_property_set_* functions are inconsistent because I
> didn't write them. I'm not sure why they take value/name. They should
> take name/value IMHO.
void object_property_set(Object *obj, Visitor *v, const char *name,
Error **errp)
s/v/value/ and you get object_property_set_*. I don't like it either,
but I was trying to be consistent...
Paolo
parent reply other threads:[~2012-07-02 12:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4FE8DFD7.2070307@us.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF19437.1070309@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).