From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SlflK-000225-Cb
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:30:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SlflE-0007bw-6z
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:29:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64266)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SlflD-0007bq-Uz
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 08:29:48 -0400
Message-ID: <4FF19437.1070309@redhat.com>
Date: Mon, 02 Jul 2012 14:29:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1340640559-15836-1-git-send-email-aliguori@us.ibm.com>
	<1340640559-15836-2-git-send-email-aliguori@us.ibm.com>
	<4FE89298.9090204@suse.de> <4FE8AF6A.3010003@us.ibm.com>
	<4FE8CE57.4050204@suse.de> <4FE8DFD7.2070307@us.ibm.com>
In-Reply-To: <4FE8DFD7.2070307@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Amit Shah <amit.shah@redhat.com>, Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 26/06/2012 00:01, Anthony Liguori ha scritto:
> The various object_property_set_* functions are inconsistent because I
> didn't write them.  I'm not sure why they take value/name.  They should
> take name/value IMHO.

void object_property_set(Object *obj, Visitor *v, const char *name,
                         Error **errp)

s/v/value/ and you get object_property_set_*.  I don't like it either,
but I was trying to be consistent...

Paolo