From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf
Date: Mon, 02 Jul 2012 15:07:45 +0200 [thread overview]
Message-ID: <4FF19D21.20005@suse.de> (raw)
In-Reply-To: <20120702125515.GA16482@stefanha-thinkpad.localdomain>
Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>> Best to use the same type, to avoid unwanted truncation or sign
>> extension.
>>
>> BlockConf can't use plain int for cyls, heads and secs, because
>> integer properties require an exact width.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> blockdev.h | 2 +-
>> hw/hd-geometry.c | 4 ++--
>> hw/ide/core.c | 2 +-
>> hw/scsi-disk.c | 2 +-
>> hw/virtio-blk.c | 2 +-
>> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> It would be nice to update the hd_geometry_lchs_guess() trace event that
> you added to use uint32_t + %u instead of int + %d.
PRIu32?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-02 13:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1340984094-5451-1-git-send-email-armbru@redhat.com>
[not found] ` <1340984094-5451-19-git-send-email-armbru@redhat.com>
2012-07-02 12:55 ` [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf Stefan Hajnoczi
2012-07-02 13:07 ` Andreas Färber [this message]
2012-07-02 14:15 ` Markus Armbruster
2012-07-02 14:34 ` Stefan Hajnoczi
2012-07-03 19:11 ` Blue Swirl
2012-07-03 20:15 ` Andreas Färber
2012-07-04 16:19 ` Paolo Bonzini
2012-07-04 16:36 ` Eric Blake
2012-07-05 18:37 ` Blue Swirl
2012-07-05 18:30 ` Blue Swirl
[not found] ` <1340984094-5451-9-git-send-email-armbru@redhat.com>
[not found] ` <CAAu8pHsKC6QMrhjUADiXT8DUrhy9HzbkN8pbYeWjM2aAE38ZwQ@mail.gmail.com>
[not found] ` <m3k3ypmjqu.fsf@blackfin.pond.sub.org>
2012-07-03 18:40 ` [Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c Blue Swirl
2012-07-04 8:24 ` Kevin Wolf
[not found] ` <1340984094-5451-4-git-send-email-armbru@redhat.com>
[not found] ` <CAAu8pHtQORnuc2G8DiWTt1QcWOKbp7L8WJ=P7HMMZCNV7L-NRQ@mail.gmail.com>
2012-07-04 15:17 ` [Qemu-devel] [PATCH 03/32] vvfat: Fix partition table Kevin Wolf
2012-07-05 9:23 ` Markus Armbruster
2012-07-05 9:55 ` Kevin Wolf
2012-07-05 11:10 ` Markus Armbruster
2012-07-05 11:14 ` Kevin Wolf
[not found] ` <1340984094-5451-5-git-send-email-armbru@redhat.com>
2012-07-04 15:23 ` [Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry Kevin Wolf
2012-07-04 16:25 ` Paolo Bonzini
2012-07-05 7:06 ` Kevin Wolf
2012-07-05 9:16 ` Markus Armbruster
2012-07-05 11:13 ` Markus Armbruster
[not found] ` <1340984094-5451-6-git-send-email-armbru@redhat.com>
2012-07-05 8:29 ` [Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly Kevin Wolf
2012-07-05 9:27 ` Markus Armbruster
[not found] ` <1340984094-5451-14-git-send-email-armbru@redhat.com>
2012-07-05 9:16 ` [Qemu-devel] [PATCH 13/32] hd-geometry: Clean up confusing use of prior translation hint Kevin Wolf
2012-07-05 9:28 ` Markus Armbruster
[not found] ` <1340984094-5451-23-git-send-email-armbru@redhat.com>
2012-07-05 11:33 ` [Qemu-devel] [PATCH 22/32] qtest: Cover qdev properties for disk geometry Kevin Wolf
2012-07-05 12:08 ` Markus Armbruster
[not found] ` <1340984094-5451-33-git-send-email-armbru@redhat.com>
2012-07-05 15:27 ` [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 Kevin Wolf
2012-07-05 16:20 ` Markus Armbruster
2012-07-05 16:39 ` Markus Armbruster
2012-07-06 8:50 ` Kevin Wolf
2012-07-11 13:10 ` Markus Armbruster
2012-07-06 14:50 ` Alexander Graf
2012-07-06 18:15 ` Markus Armbruster
2012-07-06 6:57 [Qemu-devel] [PATCH 00/32] Disk geometry cleanup Markus Armbruster
2012-07-06 6:57 ` [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF19D21.20005@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).