From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlgMB-0004IB-C1 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:08:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlgM1-0001i9-Le for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:07:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38590 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlgM1-0001ht-F3 for qemu-devel@nongnu.org; Mon, 02 Jul 2012 09:07:49 -0400 Message-ID: <4FF19D21.20005@suse.de> Date: Mon, 02 Jul 2012 15:07:45 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1340984094-5451-1-git-send-email-armbru@redhat.com> <1340984094-5451-19-git-send-email-armbru@redhat.com> <20120702125515.GA16482@stefanha-thinkpad.localdomain> In-Reply-To: <20120702125515.GA16482@stefanha-thinkpad.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, aliguori@us.ibm.com, Markus Armbruster , qemu-devel@nongnu.org Am 02.07.2012 14:55, schrieb Stefan Hajnoczi: > On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote: >> Best to use the same type, to avoid unwanted truncation or sign >> extension. >> >> BlockConf can't use plain int for cyls, heads and secs, because >> integer properties require an exact width. >> >> Signed-off-by: Markus Armbruster >> --- >> blockdev.h | 2 +- >> hw/hd-geometry.c | 4 ++-- >> hw/ide/core.c | 2 +- >> hw/scsi-disk.c | 2 +- >> hw/virtio-blk.c | 2 +- >> 5 files changed, 6 insertions(+), 6 deletions(-) >=20 > It would be nice to update the hd_geometry_lchs_guess() trace event tha= t > you added to use uint32_t + %u instead of int + %d. PRIu32? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg