From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sljpb-0001za-A1
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 12:50:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SljpW-0007L1-KE
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 12:50:34 -0400
Message-ID: <4FF1D151.6050604@suse.de>
Date: Mon, 02 Jul 2012 18:50:25 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20120627235055.GA9149@tyr.buserror.net>
In-Reply-To: <20120627235055.GA9149@tyr.buserror.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into
 generic file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Scott Wood <scottwood@freescale.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Hi Scott,

Am 28.06.2012 01:50, schrieb Scott Wood:
> Rename the file (with no changes other than fixing up the header paths)
> in preparation for refactoring into a generic e500 platform.  Also move
> it into the newly created ppc/ directory.
>=20
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
>  hw/ppc/Makefile.objs                   |    2 +-
>  hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} |   16 ++++++++--------
>  2 files changed, 9 insertions(+), 9 deletions(-)
>  rename hw/{ppce500_mpc8544ds.c =3D> ppc/e500.c} (99%)
>=20
> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
> index aa4bbeb..aa77f64 100644
> --- a/hw/ppc/Makefile.objs
> +++ b/hw/ppc/Makefile.objs
> @@ -15,7 +15,7 @@ obj-$(CONFIG_PSERIES) +=3D spapr_pci.o pci-hotplug.o =
spapr_iommu.o
>  obj-y +=3D ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o
>  obj-y +=3D ppc440_bamboo.o
>  # PowerPC E500 boards
> -obj-$(CONFIG_FDT) +=3D ppce500_mpc8544ds.o mpc8544_guts.o ppce500_spin=
.o
> +obj-$(CONFIG_FDT) +=3D ppc/e500.o mpc8544_guts.o ppce500_spin.o
>  # PowerPC 440 Xilinx ML507 reference board.
>  obj-y +=3D virtex_ml507.o
>  # PowerPC OpenPIC
[snip]

The location seems perfect for the file and nicely simplifies the file
name, but could we avoid ../ppc/ by doing:

obj-$(CONFIG_FDT) +=3D e500.o

further down after the ../ prefix has been added for the legacy files?

Also a heads-up that I have some ppce500_pci.c cleanups upcoming for
pci_host v3 series. I avoided touching the machine, so I don't see any
conflicts with your refactoring.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg