From: "Andreas Färber" <afaerber@suse.de>
To: Scott Wood <scottwood@freescale.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de,
Stuart Yoder <b08248@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] PPC: e500: add generic e500 platform
Date: Mon, 02 Jul 2012 19:04:51 +0200 [thread overview]
Message-ID: <4FF1D4B3.6090706@suse.de> (raw)
In-Reply-To: <4FF1CE8E.8040502@freescale.com>
Am 02.07.2012 18:38, schrieb Scott Wood:
> On 07/02/2012 11:33 AM, Stuart Yoder wrote:
>> On Wed, Jun 27, 2012 at 6:51 PM, Scott Wood <scottwood@freescale.com> wrote:
>>> +static QEMUMachine e500plat_machine = {
>>> + .name = "e500plat",
>>> + .desc = "e500plat",
>>> + .init = e500plat_init,
>>> + .max_cpus = 15,
>>> +};
>>
>> Can we call the generic e500 machine "ppce500"?
>
> I wanted to distinguish the platform from the common e500 code.
The machine name does not need to match the file name, so you can name
it "e500" and place it in e500plat.c or whatever. Common e500 code won't
show up as a user-visible machine I guess.
I concur that "-M e500plat" feels a bit odd for a user option. And
repeating that name in the description is not particularly helpful. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-07-02 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120627234639.GA8974@tyr.buserror.net>
[not found] ` <20120627235104.GD9149@tyr.buserror.net>
2012-07-02 16:33 ` [Qemu-devel] [PATCH 4/4] PPC: e500: add generic e500 platform Stuart Yoder
2012-07-02 16:38 ` Scott Wood
2012-07-02 17:04 ` Andreas Färber [this message]
2012-07-02 23:03 ` [Qemu-devel] [RESEND PATCH v2 0/4] PPC: e500 platform refactoring Scott Wood
2012-07-02 23:03 ` [Qemu-devel] [RESEND PATCH v2 1/4] PPC: e500: rename mpc8544ds into generic file Scott Wood
2012-07-03 10:40 ` Andreas Färber
2012-07-02 23:03 ` [Qemu-devel] [RESEND PATCH v2 2/4] PPC: e500: change internal references away from mpc8544ds Scott Wood
2012-07-02 23:03 ` [Qemu-devel] [RESEND PATCH v2 3/4] PPC: e500: split mpc8544ds machine from generic e500 code Scott Wood
2012-07-02 23:03 ` [Qemu-devel] [RESEND PATCH v2 4/4] PPC: e500: add generic e500 platform Scott Wood
2012-07-06 15:08 ` [Qemu-devel] [RESEND PATCH v2 0/4] PPC: e500 platform refactoring Alexander Graf
2012-07-07 7:39 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF1D4B3.6090706@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=b08248@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).