From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52356)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vitaly.chipounov@epfl.ch>) id 1Sloo4-0000ql-Dv
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 18:09:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vitaly.chipounov@epfl.ch>) id 1Sloo2-00082P-LF
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 18:09:19 -0400
Received: from smtp0.epfl.ch ([128.178.224.219]:34759)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <vitaly.chipounov@epfl.ch>) id 1Sloo2-000827-Bb
	for qemu-devel@nongnu.org; Mon, 02 Jul 2012 18:09:18 -0400
Message-ID: <4FF21C09.5090005@epfl.ch>
Date: Tue, 03 Jul 2012 00:09:13 +0200
From: Vitaly Chipounov <vitaly.chipounov@epfl.ch>
MIME-Version: 1.0
References: <1341224967-30471-1-git-send-email-vitaly.chipounov@epfl.ch>
	<CAMo8BfL2d+eR4Sq0x76Dr9o_A-gNzrOt+FEj2mq+S3yz5bBxyQ@mail.gmail.com>
In-Reply-To: <CAMo8BfL2d+eR4Sq0x76Dr9o_A-gNzrOt+FEj2mq+S3yz5bBxyQ@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] x86: Fixed incorrect segment base address
 addition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org

Max,

On 02.07.2012 17:18, Max Filippov wrote:
> On Mon, Jul 2, 2012 at 2:29 PM, Vitaly Chipounov
> <vitaly.chipounov@epfl.ch> wrote:
>> An instruction with address and segment size override triggers the bug.
>> inc dword ptr gs:260h[ebx*4] gets incorrectly translated to:
>> (uint32_t)(gs.base + ebx * 4 + 0x260)
>> instead of
>> gs.base + (uint32_t)(ebx * 4 + 0x260)
> Do I understand it right that this fixes address calculation for
> 64-bit mode but breaks it for compatibility mode?

You are right, it indeed breaks compatibility mode. Thanks for the
reference from the Intel manual.

I will send an updated patch.

Vitaly

>> Signed-off-by: Vitaly Chipounov <vitaly.chipounov@epfl.ch>
>> ---
>>  target-i386/translate.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-i386/translate.c b/target-i386/translate.c
>> index a902f4a..9ca7375 100644
>> --- a/target-i386/translate.c
>> +++ b/target-i386/translate.c
>> @@ -459,10 +459,10 @@ static inline void gen_op_movl_A0_seg(int reg)
>>  static inline void gen_op_addl_A0_seg(int reg)
>>  {
>>      tcg_gen_ld_tl(cpu_tmp0, cpu_env, offsetof(CPUX86State, segs[reg].base));
>> -    tcg_gen_add_tl(cpu_A0, cpu_A0, cpu_tmp0);
>>  #ifdef TARGET_X86_64
>>      tcg_gen_andi_tl(cpu_A0, cpu_A0, 0xffffffff);
>>  #endif
>> +    tcg_gen_add_tl(cpu_A0, cpu_A0, cpu_tmp0);
>>  }
>>
>>  #ifdef TARGET_X86_64
>> --
>> 1.7.4.1
>>
>>
>
>