From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slzqt-00075W-0z for qemu-devel@nongnu.org; Tue, 03 Jul 2012 05:57:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Slzqr-0005Ri-5W for qemu-devel@nongnu.org; Tue, 03 Jul 2012 05:56:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Slzqq-0005RU-Tc for qemu-devel@nongnu.org; Tue, 03 Jul 2012 05:56:57 -0400 Message-ID: <4FF2C1DE.1030109@redhat.com> Date: Tue, 03 Jul 2012 11:56:46 +0200 From: Igor Mammedov MIME-Version: 1.0 References: <1340632507-29692-1-git-send-email-imammedo@redhat.com> <4FEC4C43.3080006@siemens.com> In-Reply-To: <4FEC4C43.3080006@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "peter.maydell@linaro.org" , "aliguori@us.ibm.com" , "ehabkost@redhat.com" , "mdroth@linux.vnet.ibm.com" , "sw@weilnetz.de" , "mtosatti@redhat.com" , "qemu-devel@nongnu.org" , "agraf@suse.de" , "blauwirbel@gmail.com" , "jcmvbkbc@gmail.com" , "avi@redhat.com" , "afaerber@suse.de" , "rth@twiddle.net" On 06/28/2012 02:21 PM, Jan Kiszka wrote: > On 2012-06-25 15:55, Igor Mammedov wrote: >> v2: >> - drop usage of prev_debug_excp_handler consistently in all users >> - split from reset patches to avoid confusion of inter-dependency >> >> Compile & Run tested: >> target-i386: tcg and kvm mode >> i386-linux-user: running of /bin/ls >> Compile tested: >> xtensa-softmmu && xtensaeb-softmmu >> >> git tree for testing: >> https://github.com/imammedo/qemu/tree/x86cpu_qom_tcg_v2 >> >> >> Igor Mammedov (4): >> target-i386: drop usage of prev_debug_excp_handler >> target-xtensa: drop usage of prev_debug_excp_handler >> cleanup cpu_set_debug_excp_handler >> target-i386: move tcg initialization into x86_cpu_initfn() >> >> cpu-exec.c | 5 +---- >> exec-all.h | 2 +- >> target-i386/cpu.c | 10 ++++++++++ >> target-i386/cpu.h | 1 + >> target-i386/helper.c | 16 +--------------- >> target-xtensa/helper.c | 8 +------- >> 6 files changed, 15 insertions(+), 27 deletions(-) >> > > Looks good to me. Thanks for reviews guys. Jan, I'm still learning about review process rules. Does usually or in your case "Looks good to me" implies Reviewed-By:... ? And do I have to send pull request or ask somebody (whom?) to take patches in? > Jan > -- ----- Igor