From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sm3YX-0005wf-DY
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 09:54:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sm3YV-0005GI-HK
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 09:54:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19142)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sm3YV-0005Fx-96
	for qemu-devel@nongnu.org; Tue, 03 Jul 2012 09:54:15 -0400
Message-ID: <4FF2F97C.70803@redhat.com>
Date: Tue, 03 Jul 2012 15:54:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1341321642-24598-1-git-send-email-pbonzini@redhat.com>
	<1341321642-24598-2-git-send-email-pbonzini@redhat.com>
	<4FF2F79E.2080805@redhat.com>
In-Reply-To: <4FF2F79E.2080805@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] virtio-blk: support
	VIRTIO_BLK_F_CONFIG_WCE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: anthony@codemonkey.ws, rusty@rustcorp.com.au, qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com

Il 03/07/2012 15:46, Kevin Wolf ha scritto:
>> > Introduce a new feature bit and configuration field that provide
>> > support for toggling the cache mode between writethrough and writeback.
>> > 
>> > Also rename VIRTIO_BLK_F_WCACHE to VIRTIO_BLK_F_WCE for consistency with
>> > the spec.
> My spec (and my kernel as well) call it VIRTIO_BLK_F_FLUSH.
> 
> What's the status of the kernel and spec side of the change?

Both posted.  The spec patch that introduces VIRTIO_BLK_F_CONFIG_WCE
also renames it to VIRTIO_BLK_F_WCE, since that's really what it does.
See this old comment in the kernel (not in the latest git anymore):

       /*
        * If the FLUSH feature is supported we do have support for
        * flushing a volatile write cache on the host.  [...]
        * otherwise, we must assume that the host does not
        * perform any kind of volatile write caching.
        */

Paolo