From: Stefan Weil <sw@weilnetz.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor
Date: Tue, 03 Jul 2012 16:41:19 +0200 [thread overview]
Message-ID: <4FF3048F.2080403@weilnetz.de> (raw)
In-Reply-To: <4FF159C1.8080508@siemens.com>
Am 02.07.2012 10:20, schrieb Jan Kiszka:
> Let the text console cursor blink at 5 HZ.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> console.c | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)
>
Hi Jan,
I know that there was a "bug" report. Nevertheless I'd like
to ask whether QEMU really needs a blinking text cursor.
Blinking cursors are a matter of taste. I personally don't
want a blinking cursors. Nor do I want programs which
wake my cpu 5 times a second for something which I
don't need.
It's possible to get a blinking cursor without your patch
by redirecting QEMU's text console to one of the common
X terminal emulations (xterm, konsole, ...).
When QEMU gets GTK support, it might use a terminal
emulation which allows configurable cursor blinking.
IMHO that would be better than implementing that feature
in QEMU code.
That's why I suggest not to apply the patch.
Cheers,
Stefan
next prev parent reply other threads:[~2012-07-03 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 8:20 [Qemu-devel] [PATCH] console: Implementing blinking of cursor Jan Kiszka
2012-07-03 8:59 ` Alon Levy
2012-07-03 9:05 ` Jan Kiszka
2012-07-03 9:49 ` Alon Levy
2012-07-03 14:41 ` Stefan Weil [this message]
2012-07-03 14:50 ` Jan Kiszka
2012-07-09 14:53 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2012-07-10 19:34 ` Blue Swirl
2012-07-10 19:44 ` Jan Kiszka
2012-07-10 20:00 ` [Qemu-devel] [PATCH v3] " Jan Kiszka
2012-07-14 12:20 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3048F.2080403@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).