From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm4IE-0000du-Ce for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:41:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sm4I7-00069i-Pf for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:41:29 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sm4I7-000695-Dc for qemu-devel@nongnu.org; Tue, 03 Jul 2012 10:41:23 -0400 Message-ID: <4FF3048F.2080403@weilnetz.de> Date: Tue, 03 Jul 2012 16:41:19 +0200 From: Stefan Weil MIME-Version: 1.0 References: <4FF159C1.8080508@siemens.com> In-Reply-To: <4FF159C1.8080508@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel Am 02.07.2012 10:20, schrieb Jan Kiszka: > Let the text console cursor blink at 5 HZ. > > Signed-off-by: Jan Kiszka > --- > console.c | 26 +++++++++++++++++++++++++- > 1 files changed, 25 insertions(+), 1 deletions(-) > Hi Jan, I know that there was a "bug" report. Nevertheless I'd like to ask whether QEMU really needs a blinking text cursor. Blinking cursors are a matter of taste. I personally don't want a blinking cursors. Nor do I want programs which wake my cpu 5 times a second for something which I don't need. It's possible to get a blinking cursor without your patch by redirecting QEMU's text console to one of the common X terminal emulations (xterm, konsole, ...). When QEMU gets GTK support, it might use a terminal emulation which allows configurable cursor blinking. IMHO that would be better than implementing that feature in QEMU code. That's why I suggest not to apply the patch. Cheers, Stefan