From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmEVP-0003Ki-QH for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:35:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmEVN-0005J0-5b for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:35:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmEVM-0005II-St for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:35:45 -0400 Message-ID: <4FF39DE0.2070102@redhat.com> Date: Tue, 03 Jul 2012 19:35:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1341323574-23206-1-git-send-email-owasserm@redhat.com> <1341323574-23206-14-git-send-email-owasserm@redhat.com> In-Reply-To: <1341323574-23206-14-git-send-email-owasserm@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigBDF6DBB428B38517D321316A" Subject: Re: [Qemu-devel] [PATCH v14 13/13] Add XBZRLE statistics List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, Petter Svard , Benoit Hudzia , avi@redhat.com, Aidan Shribman , pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBDF6DBB428B38517D321316A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/03/2012 07:52 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > =20 > ## > # @MigrationInfo > @@ -282,13 +307,18 @@ > # status, only returned if status is 'active' and it is a block= > # migration > # > -# Since: 0.14.0 > +# @params: #optional a list describing all the migration capabilities = state s/@params/@capabilities/ to match the schema. also, since '*capabilities' was added in an earlier patch, this portion of the documentation should be rebased into that same patch. > +++ b/qmp-commands.hx > @@ -2093,18 +2093,28 @@ The main json-object contains the following: > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > + - "duplicate": number of duplicated pages (json-int) > + - "normal" : number of normal pages transferred (json-int) > - "disk": only present if "status" is "active" and it is a block migra= tion, > it is a json-object with the following disk information (in bytes): > - "transferred": amount transferred (json-int) > - "remaining": amount remaining (json-int) > - "total": total (json-int) > +- "params": migration capabilites state s/params/capabilities/, s/capabilites/capabilities/ > + - "xbzrle" : on/off (json-bool) on/off is not a json-bool; furthermore, MigrationCapabilityInfo (patch 2/13) is documented as being { "capability":"xbzrle", "state":true } rather than { "xbzrle":"on" } > 1. Before the first migration > - > -> { "execute": "query-migrate" } > -<- { "return": {} } > +<- { "return": { "params" : { "xbzrle" : "off" } } } which means this example does not match your code > =20 > 2. Migration is done and has succeeded > =20 > @@ -2122,6 +2132,7 @@ Examples: > <- { > "return":{ > "status":"active", > + "params" : { "xbzrle" : "off" }, neither does this. Should be: "capabilities": [ { "capability":"xbzrle", "state":false } ], > @@ -2136,6 +2147,7 @@ Examples: > <- { > "return":{ > "status":"active", > + "params" : { "xbzrle" : "off" }, and again > "ram":{ > "total":1057024, > "remaining":1053304, > @@ -2149,6 +2161,28 @@ Examples: > } > } > =20 > +5. Migration is being performed and XBZRLE is active: > + > +-> { "execute": "query-migrate" } > +<- { > + "return":{ > + "status":"active", > + "params" : { "xbzrle" : "on" }, and again --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigBDF6DBB428B38517D321316A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP853hAAoJEKeha0olJ0NqqB4H+wTQ9LPFjAzwfTTS8DIbzm9m nkxOCcU419sceL+4Ycd01LsSu3Hv66AGG3HMFqGjyY/tRXeKsTlKg0Se64JrBRF9 t4MLFCYhU6+ZbvlwejG8LqNwoFH7VNmCbsZPH+U2BVjdFbr0O+ZBkM6odDAvcwEU soXtgBAmfxazx9x+ZiV5oArwAGIAKqd9It/8VFL+PhAw+URUJT6bCNvCo0lXw67q 5XlCzYp5gCKBwNaoliEkcI1MrkO5bUN9kpLJLzgOMvHibFeHmbC0NwRQm6vTj+bC JvDMaBnYJiYh/lZ1pHJ9goWM4s5eWlXP4HzILBRv9IVudueibg3ZKlm2juN6Qxs= =3+GF -----END PGP SIGNATURE----- --------------enigBDF6DBB428B38517D321316A--