Re: [Qemu-devel] [PATCH 4/6] blkdebug: store list of active rules

[Kevin Wolf <kwolf@redhat.com>]

Am 03.07.2012 18:03, schrieb Paolo Bonzini:
> Il 03/07/2012 17:40, Kevin Wolf ha scritto:
>>>>      case ACTION_INJECT_ERROR:
>>>> -        vars->inject_errno       = rule->options.inject.error;
>>>> -        vars->inject_once        = rule->options.inject.once;
>>>> -        vars->inject_immediately = rule->options.inject.immediately;
>>>> +        if (!injected) {
>>>> +            QSIMPLEQ_INIT(&s->active_rules);
>>>> +            injected = true;
>>>> +        }
>> Does this mean that the next event will invalidate the active rules?
>> Currently it only does so if a rule for the new event exists.
> 
> No, the point of having the injected bool is exactly to keep the
> currently active rules unless a rule exists for the new event.  We
> cannot just do the QSIMPLEQ_INIT in blkdebug_debug_event, that would be
> the behavior you describe.

Ah, yes. Maybe I should learn reading sometime.

Kevin