From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN
Date: Wed, 04 Jul 2012 09:33:58 +0200 [thread overview]
Message-ID: <4FF3F1E6.1040508@redhat.com> (raw)
In-Reply-To: <CAAu8pHvEUm-0M5m96xuXNWDR4bvLB68f3n8ScVSorXrTrj7omA@mail.gmail.com>
Il 03/07/2012 21:09, Blue Swirl ha scritto:
>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf)
>> > outbuf[buflen++] = 0; // not officially assigned
>> > outbuf[buflen++] = 0; // reserved
>> > outbuf[buflen++] = id_len; // length of data following
>> > -
>> > memcpy(outbuf+buflen, str, id_len);
>> > buflen += id_len;
>> > +
>> > + if (s->wwn) {
>> > + outbuf[buflen++] = 0x1; // Binary
>> > + outbuf[buflen++] = 0x3; // NAA
>> > + outbuf[buflen++] = 0; // reserved
> C99 comments.
>
Just following the style of this code. Feel free to send a patch to
replace with #defines.
Paolo
next prev parent reply other threads:[~2012-07-04 7:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 9:41 [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 01/14] scsi: simplify handling of the VPD page length field Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN Paolo Bonzini
2012-07-03 19:09 ` Blue Swirl
2012-07-04 7:33 ` Paolo Bonzini [this message]
2012-07-05 18:03 ` Blue Swirl
2012-07-06 7:05 ` Paolo Bonzini
2012-07-07 7:48 ` Blue Swirl
2012-07-07 12:22 ` Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 03/14] atapi: implement READ DISC INFORMATION Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 04/14] scsi-disk: " Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 05/14] ISCSI: Add SCSI passthrough via scsi-generic to libiscsi Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 06/14] ISCSI: force use of sg for SMC and SSC devices Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 07/14] megasas: Add header file Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 08/14] megasas: LSI Megaraid SAS HBA emulation Paolo Bonzini
2012-07-03 19:09 ` Blue Swirl
2012-07-04 5:52 ` Hannes Reinecke
2012-07-04 7:33 ` Paolo Bonzini
2012-07-05 6:46 ` Hannes Reinecke
2012-07-02 9:41 ` [Qemu-devel] [PATCH 09/14] virtio-scsi: do not crash on adding buffers to the event queue Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 10/14] scsi: Fix data length == SCSI_SENSE_BUF_SIZE Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 11/14] scsi: Fix LOAD_UNLOAD Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 12/14] scsi: Ensure command and transfer lengths are set for all SCSI devices Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 13/14] scsi: Add basic support for SCSI media changer commands Paolo Bonzini
2012-07-02 9:41 ` [Qemu-devel] [PATCH 14/14] scsi: Fix transfer length for READ POSITION commands Paolo Bonzini
2012-07-09 16:48 ` [Qemu-devel] [PULL 00/14] SCSI updates for 2012-07-02 Anthony Liguori
2012-07-09 23:09 ` Alexander Graf
2012-07-09 23:19 ` Anthony Liguori
2012-07-10 5:57 ` Hannes Reinecke
2012-07-10 7:06 ` Paolo Bonzini
2012-07-10 12:52 ` Anthony Liguori
2012-07-10 13:01 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3F1E6.1040508@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).