From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmK6H-0000nK-Sy
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 03:34:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmK6B-0005vw-Pl
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 03:34:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SmK6B-0005vi-Hf
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 03:34:07 -0400
Message-ID: <4FF3F1E6.1040508@redhat.com>
Date: Wed, 04 Jul 2012 09:33:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1341222087-24920-1-git-send-email-pbonzini@redhat.com>
	<1341222087-24920-3-git-send-email-pbonzini@redhat.com>
	<CAAu8pHvEUm-0M5m96xuXNWDR4bvLB68f3n8ScVSorXrTrj7omA@mail.gmail.com>
In-Reply-To: <CAAu8pHvEUm-0M5m96xuXNWDR4bvLB68f3n8ScVSorXrTrj7omA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the
 disk's WWN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

Il 03/07/2012 21:09, Blue Swirl ha scritto:
>> > @@ -587,9 +588,17 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf)
>> >              outbuf[buflen++] = 0;   // not officially assigned
>> >              outbuf[buflen++] = 0;   // reserved
>> >              outbuf[buflen++] = id_len; // length of data following
>> > -
>> >              memcpy(outbuf+buflen, str, id_len);
>> >              buflen += id_len;
>> > +
>> > +            if (s->wwn) {
>> > +                outbuf[buflen++] = 0x1; // Binary
>> > +                outbuf[buflen++] = 0x3; // NAA
>> > +                outbuf[buflen++] = 0;   // reserved
> C99 comments.
> 

Just following the style of this code.  Feel free to send a patch to
replace with #defines.

Paolo