From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SmOaM-0008OH-LH
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 08:21:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SmOaH-0006rK-0B
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 08:21:34 -0400
Received: from mail-wg0-f53.google.com ([74.125.82.53]:61831)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SmOaG-0006qx-Ns
	for qemu-devel@nongnu.org; Wed, 04 Jul 2012 08:21:28 -0400
Received: by wgbfm10 with SMTP id fm10so6536968wgb.10
	for <qemu-devel@nongnu.org>; Wed, 04 Jul 2012 05:21:26 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FF4353F.8010809@redhat.com>
Date: Wed, 04 Jul 2012 14:21:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1341321642-24598-1-git-send-email-pbonzini@redhat.com>
	<1341321642-24598-3-git-send-email-pbonzini@redhat.com>
	<4FF2F87C.6010600@redhat.com> <4FF2F8DF.4020806@redhat.com>
	<4FF417F3.2090400@redhat.com>
In-Reply-To: <4FF417F3.2090400@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not
 negotiated
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: rusty@rustcorp.com.au, mst@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, kvm@vger.kernel.org

Il 04/07/2012 12:16, Kevin Wolf ha scritto:
>> > Yes.  It doesn't override cache=unsafe though.
> When the guest doesn't support flushes, cache=writeback is equivalent to
> cache=unsafe, so if you want the old behaviour back you can switch to
> cache=unsafe without additional risks.
> 
> We don't have a cache=directunsafe, though, so if you want to get the
> old behaviour of cache=none back, you're out of luck. Not sure how
> acceptable this is.

If we want to fix this, let's take the occasion to split the parameters
into cache=on/off (well, we have that already), flush=on/off, and a
device-side wce=on/off.

> Irrespective of this concern I've come to the conclusion that I agree
> and we actually must enforce this for non-unsafe mode, and not doing it
> is a bug.

Thanks!  Is that an Acked-by/Reviewed-by? :)

Paolo