From: Jan Kiszka <jan.kiszka@web.de>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.
Date: Thu, 05 Jul 2012 08:46:46 +0200 [thread overview]
Message-ID: <4FF53856.6030901@web.de> (raw)
In-Reply-To: <1341454689-8129-1-git-send-email-qemulist@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 2012-07-05 04:18, Liu Ping Fan wrote:
> Vcpu state must be set completely before receiving INIT-IPI,SIPI
>
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
> kvm.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/kvm.h b/kvm.h
> index 9c7b0ea..5b3c228 100644
> --- a/kvm.h
> +++ b/kvm.h
> @@ -198,6 +198,7 @@ static inline void cpu_synchronize_post_init(CPUArchState *env)
> {
> if (kvm_enabled()) {
> kvm_cpu_synchronize_post_init(env);
> + smp_wmb();
> }
> }
>
>
In theory, there should be no vcpu kick-off after this without some
locking operations involved that imply barriers. Did you see real
inconsistencies without this explicit one?
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-07-05 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 2:18 [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus Liu Ping Fan
2012-07-05 6:46 ` Jan Kiszka [this message]
2012-07-05 10:10 ` liu ping fan
2012-07-05 10:16 ` Jan Kiszka
2012-07-05 11:02 ` liu ping fan
2012-07-05 11:58 ` Jan Kiszka
2012-07-06 7:46 ` liu ping fan
2012-07-06 8:14 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF53856.6030901@web.de \
--to=jan.kiszka@web.de \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).